Yesterday
use adamw's suggestions. I appreciate the attention to detail!
Wed, Mar 4
The changes look fine to me.
Tue, Mar 3
Mon, Mar 2
Is it ready to be committed?
I suppose it can be landed now?
Sun, Mar 1
Address @jilles comments.
Sat, Feb 28
remove hyphen
Thank you for the review, @jilles!
Wed, Feb 25
Tue, Feb 24
Fix typos, thanks @arrowd! I'll give everyone a few days to add any more
suggestions or approve, I think this is a major feature for the ports(7)
manual!
Other than last 2 comments, LGTM.
move distfiles to ports/, thanks @arrowd!
Mon, Feb 23
I think this looks great! I have no notes for you :-)
I love this. Over to @jilles for the final say (and of course if anyone else has anything to say).
- Reword sentence about non-POSIX extensions (chose second variant suggested by ziaee).
- Change missed occurrences of 'Non-standard' -> 'Non-POSIX'.
Hmm...
The sh utility is the standard command interpreter for the system. The current version of sh is close to the IEEE Std 1003.1 (“POSIX.1”) specification for the shell. Non-POSIX extensions are marked below. This man page is not intended to be a tutorial nor a complete specification of the shell.
The sh utility is the standard command interpreter for the system. It's
behavior is standardized in the IEEE Std 1003.1 ("POSIX.1") specification
for the shell. Any extensions which are non-POSIX are marked below.
This manual is not intended to be a tutorial nor a complete specification
of the shell.This is hard because I really feel that information on standards belongs in the standardized section for standards, called STANDARDS... The first sentence is sacred, it's been there since the beginning and cannot be improved upon.
show all directories consistently in ls -F style
use arrowd's suggestion, looks great and still fits in one line, thanks!
Improve language for UPDATING and CHANGES, which also kicks the exclaimation mark out a bit father to catch the eye more.
Sat, Feb 21
Wed, Feb 18
Change 'nonstandard' -> 'non-POSIX'.
I absolutely love the base premise of what you're trying to do here. This will be a major accessibility win for the faction which supports promoting portable programming, which FreeBSD is one of the main champions of.
Tue, Feb 17
Rebase the patch.
Grammar improvements:
- Prefer American English: 'non-standard' -> 'nonstandard', 'behaviour' -> 'behavior'.
- 'a nonstandard local command' -> 'the nonstandard local command'.
Mon, Feb 16
Let's not mention the behaviour when return exits the shell during an EXIT trap action, since it's obscure and probably incorrect (I think it's supposed to work like exit, with a difference between return by itself and return "$?", but in practice it always ignores the argument during an EXIT trap action).
There's more we can do elsewhere, but this one logical change is complete and increases consistency.
