Nov 22 2024
Nov 19 2024
Nov 18 2024
Not really part of this specific problem, but jail(8) should auto-recognize list parameters because their SYSCTL_JAIL specification has a type with ",a" appended. Ideally, it would build a list of such parameters it sees like that. For non-kernel parameters like vnet.interface and zfs.dataset, putting them in the array is probably as good as its going to get.
Looks good to me.
The tests looks good. I need some time to read the code carefully ...
Manpage LGTM
Nov 17 2024
Nov 14 2024
Nov 12 2024
Thank you!
If you do not use arc diff --create/--update please upload a diff -U9999 so that there is context to be displayed.
I'm sorry, I won't do it again. I thought it would be a hilarious way to ping.
Please don't accept your own revisions. That's implied ;-)
Nov 11 2024
Nov 10 2024
Bump dates
Yes. Going to do so now.
Can you bump .Dd on all these (I'll also need to do on iwm.4 given I forgot)
Correct I missed another spot, some of my slashes were backwards.
I did miss a spot.
The table in urtw looked ever so slightly off, turns out the syntax was completely wrong (e.g. mdoc(7) says mdoc files should never have a tab for any reason, but the linter didn't see that.
Also, every network device driver manual afaik uses driver in the title, except a few, so fix those.
Once this is settled, I'll begin writing a section in style.mdoc(5) describing preferred style for hardware section in manuals, so we can make it more consistent going forward.
I'll just get this in; we'll have a few days until we'll expand anything from this file again.
Use a bullet list for hardware
While here improve some language and fold pesky lines.
In other words, I'd prefer the way iwlwifi got rendered over the way rtw88 got rendered.
I'll leave the comment here (applies to github as well I would assume):
Nov 3 2024
Oct 31 2024
+ s/Nm iwmfw/Xr iwmfw 4/
+ adjust HARDWARE to proposed display block convention
Oct 30 2024
I'd like to make it consistent if possible. The patch on github switches from Bl to Bd so that the extra spaces used for alignment will render.
Oct 26 2024
Oct 25 2024
Okay, thanks Graham! That sounds good. Next push will revert proposed example prompts.
(Sorry, I forgot to click "submit" when I looked at this a few days ago.
Oct 23 2024
Correct my backwards forward slash, thank you for your patience.
Oct 20 2024
mention 802.11a, and convert example to cidr notation! Thank you so much, many people in the community have wanted this for a long time. I'll do the rest of them in one review.
192.0.2.20/24 (and we can ditch the netmask line). 192.0.2.0 is the network address.
I wonder if we want to add a note forward to iwlwifi(4). @emaste I seem to remember you having a review open to switch defaults. Do we want to leave a note here at least that all these devices are equally supported by iwlwifi(4)?