Wed, Sep 16
Disclaimer: didn't read the review. However, read the diff at EuroBSDCon together with Alexander.
I missed these omitted .Dd bumps before
forgot a stray "type"
Tue, Sep 15
"ng_ip_input(4) -- IPv4 input netgraph node"?
Sun, Sep 13
Hi. I have committed the update, but since I have forgotten to link this review to the commit message, Phabricator is not aware of that, sorry.
Thu, Sep 10
Mon, Sep 7
Nice move. Thanks!
I'm OK with "promoting" these example scripts into actual commands. However, since this is a user-facing change for Jails, I would suggest setting Relnotes: yes, as some users already install jib,jng into /usr/local/sbin.
I would also like to get some feedback from people using jails to do some interesting things, rather than just isolating/forwarding a few services (like I do).
Sat, Sep 5
Fri, Sep 4
@kfv thank you so much for pointing me at the tests and working through the logic with me to make sure we do the right thing (updating the test now that we return 0 instead of ELOOP)
Excellent work on this. Thanks!
ATF update
Reduce comments
Thu, Sep 3
Amazing!
Fix jng to incorporate kernel ng_ether_sanitize_ifname() logic
