I don't understand. What assumption are we making at compile time?

I do very much approve of the conceptual change, and this code seems clear and good to me, but I am too junior at C programming to be the final word on mechanical changes to drivers. I asked some senior colleagues to take a look.

Since ecdf4409f910

Thanks for doing this!

Thanks for tagging me!

Awesome!

Patch doesn't apply to main, please rebase

Thank you so much for doing this. Ufs is amazing and it doesn't get enough love

Your use of angle macro instead of less-than/greater-than is correct. mandoc renders Aq/Ao/Ac to UTF-8 as Mathematical Angle Brackets (U+27E8 and U+27E9), and the default FreeBSD console font for higher resolution displays is missing this character. I reported these upstream to the fonts author.

That syntax doesn't work for me on FreeBSD console, and I know others too, so I took it for granted. I'll dig in a bit when I get back to my desk. Just to give some idea on the range of moving parts:

This is fine with me, but I would wait for @imp or even anyone someone else from Loader like @kevans or @tsoome. It sounds like he might not want to declare that space works and then they're committed to supporting that, or making things consistent towards that.

Many tools expect git commit titles to be 50 or less characters

Ping

Ping

Ping

I'm happy to land it, but I don't know if we should wait for @des

Okay, over to USB

Thanks Sarah!

Why? When you call invoke less as "more" it works exactly the same but gives a classic BSD status line at the bottom.

Roff requires one sentence per line, so period always starts a new line. The linter will catch these basic issues, you can use it with mandoc -Tlint here/is/the/manual.

I agree with this from a doc principle but I don't know enough from a C standpoint, I'd like @emaste or @imp to check it.

remove set eficom

Hey Rick! Thanks for the ping. Tip: use the linter,

mandoc -Tlint here/is/the/manual

this uses saner code variant for change just done recently

I think this looks great! Let's wait for a second opinion on the content and then I'd be happy to take this.

Unfortunately parsing diffs from git format-patch from phabricator side seems to be broken. It only shows the first (and the most trivial) commit. I'm using basic git diff here.

Personally, I prefer a manual to stick strictly to its own contents and avoid referencing other libraries in the main text which keeps it concise and easier to read

This is such a beautifully structured manual. People often abuse .Sh when really they should be subsections of DESCRIPTION. Thanks for the patch Artem!

Thanks for doing this!

I still do (nonblocking, if anyone else is free) but I'm swamped at $dayjob and idk when I'll be able to get to it.

Thanks for the ping! I get busy and forget about stuff so I really appreciate pings!

Sunpoet committed this from bugzilla

I tried to test this, but the patch failed to apply

Ah, I misunderstood then, sorry. Over lunch I'll test this.

I don't think this is the diff you intended to upload based on the commit message title. Also, please format patches with -U9999 so we can see the context

Phabricator is disconnected somehow, but I updated this and just commit it

corrected info, tagged bug. thanks @adrian!

I think we have made a lot of progress on this, and the greatest points of controversy are resolved. To me, if this is acceptable to the major stake holders, I can merge this and we can continue iterating in the tree.

If the point is to align the two driver strings, I think that's one logical change and could/should be one commit.

I think if you want to make them the same you should remove FreeBSD from both. If people search logs for FreeBSD they shouldn't get these drivers, I think.

correctly capitalizing MegaRAID, and expanding version all sound good to me.

In D54433#1244080, @pi wrote:

Will it also explain pkgbasify ?

I think my text still could use improvement, but to me almost all of these suggestions is going the wrong way towards "explain them to death".