Page MenuHomeFreeBSD
Differential D50126

UPDATING: Strengthen recommendations
ClosedPublic
Actions

Authored by ziaee on Fri, May 2, 10:02 PM.
Tags
None
Referenced Files
F116379754: D50126.id154727.diff
Tue, May 6, 12:34 AM
F116359454: D50126.diff
Mon, May 5, 9:32 PM
Unknown Object (File)
Mon, May 5, 7:12 AM
Unknown Object (File)
Mon, May 5, 7:04 AM
Unknown Object (File)
Sun, May 4, 2:37 PM
Subscribers
brooks

Details

Reviewers
carlavilla
imp
mhorne
Commits
rGca9131b72975: UPDATING: Strengthen recommendations
Summary

Strengthen recommendations for ports_modules by adding a separate note.
Use the unused [2] to add a note about creating backups.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ziaee requested review of this revision.Fri, May 2, 10:02 PM
ziaee created this revision.
Harbormaster completed remote builds in B63846: Diff 154727.Fri, May 2, 10:02 PM
brooks added a subscriber: brooks.Fri, May 2, 10:18 PM

To fix an a separate commit: the foot note ordering is quite jarring.

UPDATING
2195

Maybe not to change with this commit, but the wording feels very 1990s. Talking about backups might be more friendly.

2196

Would this make more sense between buildkernel and installkernel? If you do it too early you may break your system if a reboot happens before you finish the other steps.

ziaee updated this revision to Diff 154765.Sat, May 3, 11:06 PM

That's a great idea, thank you! I didn't notice because I put them in src.conf.

Harbormaster completed remote builds in B63860: Diff 154765.Sat, May 3, 11:06 PM
ziaee marked 2 inline comments as done.Sat, May 3, 11:07 PM
mhorne accepted this revision.Mon, May 5, 3:03 PM
mhorne added inline comments.
UPDATING
2195

Yeah, "level 0 dumps" is a foreign term to me.

This revision is now accepted and ready to land.Mon, May 5, 3:03 PM
ziaee added a comment.Mon, May 5, 3:54 PM

A level 0 dump is like dd. It gets absolutely everything, unlike a boot environment. I'll work on that after I merge this one.

ziaee added a comment.Mon, May 5, 3:54 PM

Thank you gentlemen.

Closed by commit rGca9131b72975: UPDATING: Strengthen recommendations (authored by ziaee). · Explain WhyMon, May 5, 4:38 PM
This revision was automatically updated to reflect the committed changes.
ziaee added a commit: rGca9131b72975: UPDATING: Strengthen recommendations.
brooks added a comment.Mon, May 5, 6:25 PM
In D50126#1144298, @ziaee wrote:

A level 0 dump is like dd. It gets absolutely everything, unlike a boot environment. I'll work on that after I merge this one.

FWIW, it's a reference to dump -0.

Revision Contents
Changeset List

PathSize
15 lines

Diff 154882

View Options

UPDATING

Loading...