Page MenuHomeFreeBSD

stand: Revert adding Spleen 32x64
AbandonedPublic

Authored by ziaee on May 8 2025, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 7, 1:12 PM
Unknown Object (File)
Sun, Jul 6, 9:46 AM
Unknown Object (File)
Thu, Jul 3, 8:50 AM
Unknown Object (File)
Thu, Jun 26, 12:04 AM
Unknown Object (File)
Wed, Jun 18, 2:21 PM
Unknown Object (File)
Sat, Jun 14, 8:00 PM
Unknown Object (File)
May 30 2025, 8:41 PM
Unknown Object (File)
May 25 2025, 9:16 AM
Subscribers

Details

Summary

Adding a bigger font exposes a bug in the loader font selection which
causes 1080p displays to get too big of a font if one is available. Revert this commit until
someone more knowledgable can improve the font selection algorithm.
Further, I did make a mistake in the linked commit message, it does say
"Reviewed by" where it should mostly say "Discussed with", except emaste
who was actually absent from the discussion except being mentioned.

PR: 286674
Reverts: 1ec2c8b2f364cc (Enable Spleen 32x64 in the bootloader)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64013
Build 60897: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.May 8 2025, 7:13 PM
kevans added a subscriber: kevans.

Pointy-hat: ziaee

IMO you don't get the privilege of wearing the hat just because you didn't have a smaller display to test on. I don't think it's unreasonable to expect that we would choose a sensible font with all of these options at hand.

This revision is now accepted and ready to land.May 8 2025, 7:40 PM

Closing, tsoome committed the fix for the bug this exposed this today.