Page MenuHomeFreeBSD

pkgbase: allow update-packages for first-run of packaging
ClosedPublic

Authored by kevans on Jan 19 2021, 4:32 AM.
Tags
None
Referenced Files
F132158337: D28229.id82521.diff
Tue, Oct 14, 7:25 AM
Unknown Object (File)
Sun, Oct 12, 1:52 AM
Unknown Object (File)
Thu, Oct 9, 7:58 PM
Unknown Object (File)
Thu, Oct 9, 7:58 PM
Unknown Object (File)
Thu, Oct 9, 5:16 PM
Unknown Object (File)
Wed, Sep 17, 3:55 PM
Unknown Object (File)
Sep 1 2025, 11:45 PM
Unknown Object (File)
Aug 25 2025, 8:43 AM
Subscribers

Details

Reviewers
manu
Group Reviewers
pkgbase
Summary

If ${REPODIR}/${PKG_ABI} does not exist when we begin real-update-packages,
skip the comparison with the non-existent previous repository and just
finish the repo off. This allows external scripts to just assume they can
run update-packages rather than figuring out if they'd previously run
packages for this Version/Arch combo.

PKG_VERSION_FROM_DIR was added so that we could perhaps detect the three
distinct cases:

1.) If the repo has not yet been created, PKG_VERSION_FROM_DIR will be

empty.

2.) If the repo is in some intermediate state between created and fully

initialized, PKG_VERSION_FROM_DIR may point to the ABI directory.

3.) If the repo is fully initialized, then PKG_VERSION_FROM_DIR points to

the latest build to compare to.

Option #2 is explicitly unhandled at the moment, but this is no different
than it was before.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36330
Build 33219: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 19 2021, 7:31 AM

If make update-packages creates and or updates the package repo, the difference between this and make packages is confusing. Can we just remove make packages and rename this to make packages so it's a bit cleaner?