Page MenuHomeFreeBSD

shurd (Stephen Hurd)
User

Projects

User Details

User Since
Jun 19 2014, 6:57 AM (590 w, 5 d)

Recent Activity

Sun, Oct 12

shurd committed R11:711c719d96de: comms/syncterm: Update to v1.7 (authored by shurd).
comms/syncterm: Update to v1.7
Sun, Oct 12, 3:31 AM

Mar 22 2025

shurd added inline comments to D49216: sound: Implement /dev/dsp as a router device.
Mar 22 2025, 5:55 PM
shurd added inline comments to D49216: sound: Implement /dev/dsp as a router device.
Mar 22 2025, 5:50 PM

Mar 21 2025

shurd updated the diff for D49423: Make newly POSIX functions visible (take 2).
  • Cleanup and document
Mar 21 2025, 5:55 PM
shurd updated the diff for D49423: Make newly POSIX functions visible (take 2).
  • Remove last new #error
Mar 21 2025, 5:14 PM
shurd updated the diff for D49423: Make newly POSIX functions visible (take 2).
  • Convert #error to #warning
Mar 21 2025, 5:13 PM
shurd added a comment to D49423: Make newly POSIX functions visible (take 2).

So, I ran egrep -r '__[A-Z0-9]*_VISIBLE' /usr/ports and now I'm very sad.

Mar 21 2025, 4:17 PM
shurd updated the diff for D49423: Make newly POSIX functions visible (take 2).
  • Actually undefine things we say we do.
Mar 21 2025, 2:51 PM
shurd updated the diff for D49423: Make newly POSIX functions visible (take 2).
  • Typo
Mar 21 2025, 2:41 PM
shurd updated the diff for D49423: Make newly POSIX functions visible (take 2).
  • Honing in on requirements
  • Allow C version to be upgraded via _CXX_SOURCE and _ISOCXX_SOURCE
Mar 21 2025, 2:41 PM
shurd added a comment to D49423: Make newly POSIX functions visible (take 2).

So I think there's really two classes of things it would be nice to define/enforce... what we do with a _*_SOURCE conflict, and what we do about a user defining __*_VISIBLE.

Mar 21 2025, 1:55 PM

Mar 20 2025

shurd added inline comments to D49423: Make newly POSIX functions visible (take 2).
Mar 20 2025, 11:40 PM
shurd added a comment to D49423: Make newly POSIX functions visible (take 2).
In D49423#1127234, @imp wrote:

I also noticed that if you ask for _XOPEN_SOURCE 800, you get POSIX_C_SOURCE of 202405 unconditionally and irregardless of what you'd defined earlier.
And defining POSIX_C_SOURCE takes precedence over all the other _FOO_SOURCE things, which kinda is backwards I think.

Mar 20 2025, 11:38 PM
shurd added inline comments to D49423: Make newly POSIX functions visible (take 2).
Mar 20 2025, 11:35 PM
shurd updated the diff for D49423: Make newly POSIX functions visible (take 2).
  • More enforcement
Mar 20 2025, 11:28 PM
shurd added a comment to D49423: Make newly POSIX functions visible (take 2).
In D49423#1127228, @imp wrote:

I need to update the XOPEN_SOURCE and POSIX_C_SOURCE part of cdefs(9) to indicate the 'paired values' that are legal. Like 800 and 202405.
And there's values implied by different POSIX_C_SOURCE as well wrt language defines. When paired with a language standard, these combos should likely be allowed. POSIX_C_SOURCE 202405 and I think C23 or 200809 plus C99, etc.
So pedantically, you should pick one or the other, we may need to relax a little to allow the different pairings that make sense together.
Do you think it would make sense for me to update cdefs.9 to include this matrix?

Mar 20 2025, 11:28 PM
shurd updated the diff for D49423: Make newly POSIX functions visible (take 2).
  • Warn/error on conflicting programming environments
Mar 20 2025, 10:58 PM
shurd updated the diff for D49423: Make newly POSIX functions visible (take 2).
  • Error on conflicting programming environments for exp-run
Mar 20 2025, 6:22 PM
shurd added a comment to D49423: Make newly POSIX functions visible (take 2).

I wonder if it's a good idea to take on the whole set of mutually exclusive environment selection macros with this...

Mar 20 2025, 11:21 AM
shurd added a comment to D49423: Make newly POSIX functions visible (take 2).

Hrm...

./usr.sbin/rtsold/rtsol.c:#define	__BSD_VISIBLE	1	/* IN6ADDR_LINKLOCAL_ALLROUTERS_INIT */
./crypto/openssh/openbsd-compat/fnmatch.h:#define __BSD_VISIBLE 1
./sys/contrib/openzfs/include/os/freebsd/spl/sys/ccompile.h:#define	__BSD_VISIBLE 1

Would these count?

Mar 20 2025, 10:06 AM
shurd added a comment to D49423: Make newly POSIX functions visible (take 2).

Using || __BSD_VISIBLE on all of the symbols that were previously only under __BSD_VISIBLE will be needed for this to MFC, so perhaps do it here as well? (14.2 default __POSIX_VISIBLE appears to be 200809)

Mar 20 2025, 8:09 AM
shurd abandoned D49421: Keep POSIX things controllable with __BSD_VISIBLE.

Revert was pushed. See https://reviews.freebsd.org/D49423 for v2 of the patch.

Mar 20 2025, 7:51 AM
shurd requested review of D49423: Make newly POSIX functions visible (take 2).
Mar 20 2025, 7:50 AM
shurd abandoned D49422: Revert Make newly POSIX functions visible.

Revision pushed as 415a0ce02c9ee2c15c7973b2dfbddda71f6344a2

Mar 20 2025, 7:42 AM
shurd added a reverting change for rG9d0eea9422d0: Make newly POSIX functions visible: rG415a0ce02c9e: Revert Make newly POSIX functions visible.
Mar 20 2025, 7:42 AM
shurd committed rG415a0ce02c9e: Revert Make newly POSIX functions visible (authored by shurd).
Revert Make newly POSIX functions visible
Mar 20 2025, 7:42 AM
shurd added a reverting change for rGd7efac1be144: Add missing ||: rG415a0ce02c9e: Revert Make newly POSIX functions visible.
Mar 20 2025, 7:42 AM
shurd added a reverting change for D47859: Make new POSIX functions visible: rG415a0ce02c9e: Revert Make newly POSIX functions visible.
Mar 20 2025, 7:42 AM
shurd added a comment to D49421: Keep POSIX things controllable with __BSD_VISIBLE.

Alternatively, I have a revert commit ready as well:
https://reviews.freebsd.org/D49422

Mar 20 2025, 7:18 AM
shurd added a reverting change for rG9d0eea9422d0: Make newly POSIX functions visible: D49422: Revert Make newly POSIX functions visible.
Mar 20 2025, 7:18 AM
shurd added a reverting change for rGd7efac1be144: Add missing ||: D49422: Revert Make newly POSIX functions visible.
Mar 20 2025, 7:18 AM
shurd added a reverting change for D47859: Make new POSIX functions visible: D49422: Revert Make newly POSIX functions visible.
Mar 20 2025, 7:18 AM
shurd requested review of D49422: Revert Make newly POSIX functions visible.
Mar 20 2025, 7:18 AM
shurd requested review of D49421: Keep POSIX things controllable with __BSD_VISIBLE.
Mar 20 2025, 7:05 AM
shurd committed rGd7efac1be144: Add missing || (authored by shurd).
Add missing ||
Mar 20 2025, 12:56 AM

Mar 19 2025

shurd committed rG9d0eea9422d0: Make newly POSIX functions visible (authored by shurd).
Make newly POSIX functions visible
Mar 19 2025, 11:45 PM
shurd closed D47859: Make new POSIX functions visible.
Mar 19 2025, 11:45 PM
shurd added a comment to D47859: Make new POSIX functions visible.

Thanks for the review, I'm very happy to have a picky reviewer on this one especially.

Mar 19 2025, 11:39 PM
shurd updated the diff for D47859: Make new POSIX functions visible.
  • Remove extra XX comment
Mar 19 2025, 11:37 PM
shurd updated the diff for D47859: Make new POSIX functions visible.
  • More feedback
Mar 19 2025, 11:27 PM
shurd added a comment to D49408: rk_grf_gpio.4: Minor polish.

It may be worth noting that the only example of SPDX in style(9) that I see has SPDX before the copyright.

Mar 19 2025, 4:36 PM
shurd added inline comments to D47859: Make new POSIX functions visible.
Mar 19 2025, 6:20 AM
shurd updated the diff for D47859: Make new POSIX functions visible.
  • Address feedback
Mar 19 2025, 6:14 AM
shurd added inline comments to D47859: Make new POSIX functions visible.
Mar 19 2025, 6:14 AM
shurd added inline comments to D47859: Make new POSIX functions visible.
Mar 19 2025, 6:07 AM
shurd added inline comments to D47859: Make new POSIX functions visible.
Mar 19 2025, 6:05 AM
shurd accepted D49408: rk_grf_gpio.4: Minor polish.

Looks good, thanks!

Mar 19 2025, 5:56 AM

Mar 18 2025

shurd closed D49400: Disable HS200 in attach.
Mar 18 2025, 5:04 PM
shurd committed rG0f684b5aec50: Disable HS200 on rockchip_dwmmc in attach (authored by shurd).
Disable HS200 on rockchip_dwmmc in attach
Mar 18 2025, 5:04 PM
shurd committed rG0832a409c21b: Add driver for the RK3328 GPIO_MUTE pin (authored by shurd).
Add driver for the RK3328 GPIO_MUTE pin
Mar 18 2025, 5:01 PM
shurd closed D49399: Add driver for the RK3328 GPIO_MUTE pin.
Mar 18 2025, 5:01 PM
shurd updated the diff for D49399: Add driver for the RK3328 GPIO_MUTE pin.
  • Remove unneeded headers
Mar 18 2025, 1:15 AM
shurd updated the diff for D49399: Add driver for the RK3328 GPIO_MUTE pin.
  • Update .c file per style(9) as well.
Mar 18 2025, 1:08 AM
shurd updated the diff for D49399: Add driver for the RK3328 GPIO_MUTE pin.
  • Another typo, CPIO -> GPIO
Mar 18 2025, 12:38 AM
shurd requested review of D49400: Disable HS200 in attach.
Mar 18 2025, 12:35 AM
shurd added reviewers for D49400: Disable HS200 in attach: manu, imp.
Mar 18 2025, 12:35 AM
shurd updated the diff for D49399: Add driver for the RK3328 GPIO_MUTE pin.
  • was->were
Mar 18 2025, 12:29 AM
shurd added inline comments to D49399: Add driver for the RK3328 GPIO_MUTE pin.
Mar 18 2025, 12:27 AM
shurd updated the diff for D49399: Add driver for the RK3328 GPIO_MUTE pin.
  • Address manual feedback
Mar 18 2025, 12:25 AM

Mar 17 2025

shurd updated the diff for D49399: Add driver for the RK3328 GPIO_MUTE pin.
  • Fix copyright and update wrapping
Mar 17 2025, 10:04 PM
shurd updated the diff for D49399: Add driver for the RK3328 GPIO_MUTE pin.
  • Fix copyright
Mar 17 2025, 9:57 PM
shurd added a reviewer for D49399: Add driver for the RK3328 GPIO_MUTE pin: linimon.
Mar 17 2025, 9:54 PM
shurd requested review of D49399: Add driver for the RK3328 GPIO_MUTE pin.
Mar 17 2025, 9:50 PM

Feb 11 2025

shurd committed R11:263eda46dc0a: comms/syncterm: Update to v1.6 (authored by shurd).
comms/syncterm: Update to v1.6
Feb 11 2025, 7:18 PM

Feb 9 2025

shurd closed D48573: comms/wsjtz: Give bin/jt9 an executable stack.
Feb 9 2025, 3:49 AM
shurd committed R11:cbc58c695e80: comms/wsjtz: Give bin/jt9 an executable stack (authored by shurd).
comms/wsjtz: Give bin/jt9 an executable stack
Feb 9 2025, 3:49 AM
shurd closed D48572: comms/wsjtx: Give bin/jt9 an executable stack.
Feb 9 2025, 3:42 AM
shurd committed R11:d3169967f129: comms/wsjtx: Give bin/jt9 an executable stack (authored by shurd).
comms/wsjtx: Give bin/jt9 an executable stack
Feb 9 2025, 3:42 AM

Jan 21 2025

shurd committed R11:513f684dcfa8: comms/syncterm: Update to v1.4 (authored by shurd).
comms/syncterm: Update to v1.4
Jan 21 2025, 4:31 PM
shurd closed D48571: comms/syncterm: Update to v1.4.

Pushed as 513f684dcfa8fe242cc540ddb65793eacdd14b34

Jan 21 2025, 4:31 PM
shurd requested review of D48573: comms/wsjtz: Give bin/jt9 an executable stack.
Jan 21 2025, 1:22 AM
shurd added a comment to D48572: comms/wsjtx: Give bin/jt9 an executable stack.

I guess there's no hamradio@ group in here.

Jan 21 2025, 1:20 AM
shurd requested review of D48572: comms/wsjtx: Give bin/jt9 an executable stack.
Jan 21 2025, 1:18 AM
shurd added a comment to D48571: comms/syncterm: Update to v1.4.
In D48571#1107815, @jrm wrote:
  • it might be helpful (at some point) to upstream the patch
Jan 21 2025, 12:55 AM
shurd updated the diff for D48571: comms/syncterm: Update to v1.4.

Apply portfmt -D patch

Jan 21 2025, 12:54 AM

Jan 20 2025

shurd added reviewers for D48571: comms/syncterm: Update to v1.4: Ports Committers, fernape.
Jan 20 2025, 9:36 PM
shurd requested review of D48571: comms/syncterm: Update to v1.4.
Jan 20 2025, 9:35 PM

Jan 18 2025

shurd committed rG9e659ecfb231: Expose POSIX functions incorporated into C23 (authored by shurd).
Expose POSIX functions incorporated into C23
Jan 18 2025, 8:20 PM
shurd committed rGbc14b1ebce0e: Expose POSIX functions incorporated into C23 (authored by shurd).
Expose POSIX functions incorporated into C23
Jan 18 2025, 8:18 PM

Dec 27 2024

shurd accepted D48221: kernel: Clarify kern.elfNN.nxstack sysctl description.

👍

Dec 27 2024, 11:36 PM

Dec 2 2024

shurd abandoned D41201: Initial port to i.MX6UL for SBC-EC9100.
Dec 2 2024, 5:42 PM
shurd added reviewers for D47859: Make new POSIX functions visible: des, allanjude.
Dec 2 2024, 3:45 AM
shurd requested review of D47859: Make new POSIX functions visible.
Dec 2 2024, 3:41 AM

Dec 1 2024

shurd added a comment to D47856: Expose POSIX functions incorporated into C23.

Asking for the src bit back though, wish me luck. :D

Dec 1 2024, 5:24 PM
shurd added a comment to D47856: Expose POSIX functions incorporated into C23.

As it happens, I no longer have a commit bit... here's the message I was going to use:

Dec 1 2024, 5:23 PM
shurd added reviewers for D47856: Expose POSIX functions incorporated into C23: fuz, emaste, kevans, des, brooks.

Add more reviewers who have made/reviewed C23 changes to these files.

Dec 1 2024, 4:50 PM
shurd added reviewers for D47856: Expose POSIX functions incorporated into C23: imp, kib.

Adding reviewers, there doesn't seem to be a "standards" group.

Dec 1 2024, 4:40 PM
shurd requested review of D47856: Expose POSIX functions incorporated into C23.
Dec 1 2024, 4:38 PM

Oct 1 2024

shurd added inline comments to D46186: iflib: Add iflib managed counters support.
Oct 1 2024, 6:43 PM
shurd added inline comments to D46186: iflib: Add iflib managed counters support.
Oct 1 2024, 6:40 PM
shurd added inline comments to D46186: iflib: Add iflib managed counters support.
Oct 1 2024, 1:20 AM

Apr 21 2024

shurd added a reviewer for D44861: Initial cut at Intel AX210 bluetooth support: adrian.

Going on vacation for a couple weeks, and will look at this again when I get back... adding adrian@ as a reviewer, feel free to add more appropriate reviewers as actionable feedback will be welcome when I return.

Apr 21 2024, 5:16 PM
shurd updated the diff for D44861: Initial cut at Intel AX210 bluetooth support.
  • Update manpage
Apr 21 2024, 7:17 AM

Apr 20 2024

shurd updated the diff for D44861: Initial cut at Intel AX210 bluetooth support.
  • Add macros for TLV types
Apr 20 2024, 5:54 PM
shurd updated the diff for D44861: Initial cut at Intel AX210 bluetooth support.
  • Retry reset command up to twice.
Apr 20 2024, 6:11 AM

Apr 19 2024

shurd added a comment to D44861: Initial cut at Intel AX210 bluetooth support.

Tested with Google Pixel Buds A... with virtual_oss, pairs and right channel works.

Apr 19 2024, 10:29 PM
shurd updated the diff for D44861: Initial cut at Intel AX210 bluetooth support.
  • Fix comment.
Apr 19 2024, 3:57 AM
shurd updated the diff for D44861: Initial cut at Intel AX210 bluetooth support.
  • Add to devd
Apr 19 2024, 3:51 AM
shurd retitled D44861: Initial cut at Intel AX210 bluetooth support from Initial work... doesn't. to Initial cut at Intel AX210 bluetooth support.
Apr 19 2024, 3:48 AM
shurd requested review of D44861: Initial cut at Intel AX210 bluetooth support.
Apr 19 2024, 3:46 AM