User Details
- User Since
- Jun 19 2014, 6:57 AM (590 w, 5 d)
Sun, Oct 12
Mar 22 2025
Mar 21 2025
- Cleanup and document
- Remove last new #error
- Convert #error to #warning
So, I ran egrep -r '__[A-Z0-9]*_VISIBLE' /usr/ports and now I'm very sad.
- Actually undefine things we say we do.
- Typo
- Honing in on requirements
- Allow C version to be upgraded via _CXX_SOURCE and _ISOCXX_SOURCE
So I think there's really two classes of things it would be nice to define/enforce... what we do with a _*_SOURCE conflict, and what we do about a user defining __*_VISIBLE.
Mar 20 2025
- More enforcement
- Warn/error on conflicting programming environments
- Error on conflicting programming environments for exp-run
I wonder if it's a good idea to take on the whole set of mutually exclusive environment selection macros with this...
Hrm...
./usr.sbin/rtsold/rtsol.c:#define __BSD_VISIBLE 1 /* IN6ADDR_LINKLOCAL_ALLROUTERS_INIT */ ./crypto/openssh/openbsd-compat/fnmatch.h:#define __BSD_VISIBLE 1 ./sys/contrib/openzfs/include/os/freebsd/spl/sys/ccompile.h:#define __BSD_VISIBLE 1
Would these count?
Using || __BSD_VISIBLE on all of the symbols that were previously only under __BSD_VISIBLE will be needed for this to MFC, so perhaps do it here as well? (14.2 default __POSIX_VISIBLE appears to be 200809)
Revert was pushed. See https://reviews.freebsd.org/D49423 for v2 of the patch.
Revision pushed as 415a0ce02c9ee2c15c7973b2dfbddda71f6344a2
Alternatively, I have a revert commit ready as well:
https://reviews.freebsd.org/D49422
Mar 19 2025
Thanks for the review, I'm very happy to have a picky reviewer on this one especially.
- Remove extra XX comment
- More feedback
It may be worth noting that the only example of SPDX in style(9) that I see has SPDX before the copyright.
- Address feedback
Mar 18 2025
- Remove unneeded headers
- Update .c file per style(9) as well.
- Another typo, CPIO -> GPIO
- was->were
- Address manual feedback
Mar 17 2025
- Fix copyright and update wrapping
- Fix copyright
Feb 11 2025
Feb 9 2025
Jan 21 2025
Pushed as 513f684dcfa8fe242cc540ddb65793eacdd14b34
I guess there's no hamradio@ group in here.
Apply portfmt -D patch
Jan 20 2025
Jan 18 2025
Dec 27 2024
Dec 2 2024
Dec 1 2024
Asking for the src bit back though, wish me luck. :D
As it happens, I no longer have a commit bit... here's the message I was going to use:
Add more reviewers who have made/reviewed C23 changes to these files.
Adding reviewers, there doesn't seem to be a "standards" group.
Oct 1 2024
Apr 21 2024
Going on vacation for a couple weeks, and will look at this again when I get back... adding adrian@ as a reviewer, feel free to add more appropriate reviewers as actionable feedback will be welcome when I return.
- Update manpage
Apr 20 2024
- Add macros for TLV types
- Retry reset command up to twice.
Apr 19 2024
Tested with Google Pixel Buds A... with virtual_oss, pairs and right channel works.
- Fix comment.
- Add to devd