Page MenuHomeFreeBSD
Differential D49399

Add driver for the RK3328 GPIO_MUTE pin
ClosedPublic
Actions

Authored by shurd on Mon, Mar 17, 9:50 PM.

Details

Reviewers
andrew
manu
linimon
Commits
rG0832a409c21b: Add driver for the RK3328 GPIO_MUTE pin
Summary

This is used in in the ROC-RK3328-CC to control a regulator.

Test Plan

Tested on ROC-RK3328-CC board

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

shurd created this revision.Mon, Mar 17, 9:50 PM
Herald added a reviewer: andrew. · View Herald TranscriptMon, Mar 17, 9:50 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: ziaee, emaste, imp. · View Herald Transcript
shurd requested review of this revision.Mon, Mar 17, 9:50 PM
Harbormaster completed remote builds in B62947: Diff 152365.Mon, Mar 17, 9:50 PM
shurd added a reviewer: linimon.Mon, Mar 17, 9:54 PM
shurd updated this revision to Diff 152367.Mon, Mar 17, 9:57 PM
  • Fix copyright
Harbormaster completed remote builds in B62948: Diff 152367.Mon, Mar 17, 9:57 PM
shurd updated this revision to Diff 152368.Mon, Mar 17, 10:04 PM
  • Fix copyright and update wrapping
Harbormaster completed remote builds in B62949: Diff 152368.Mon, Mar 17, 10:04 PM
ziaee added a comment.Mon, Mar 17, 10:22 PM

I don't know what this does, but thank you for writing a manual with it! Some minor style suggestions and questions:

share/man/man4/man4.aarch64/rk_grf_gpio.4
2

The project this - was added for was abandoned

3

You could use SPDX only now if you want, there's an example in style(9)

31

This is more than one line. How's this? The rendered line barely fits on standard console.

38

Does it support the gpio or only the gpio_mute pin?
How can people use it? What does it do? That would be really nice in this section.

41–44
53

I see no reason why we couldn't, but we don't usually say "device driver" lately.

58
shurd updated this revision to Diff 152371.Tue, Mar 18, 12:25 AM
  • Address manual feedback
Harbormaster completed remote builds in B62950: Diff 152371.Tue, Mar 18, 12:25 AM
shurd marked 7 inline comments as done.Tue, Mar 18, 12:27 AM
shurd added inline comments.
share/man/man4/man4.aarch64/rk_grf_gpio.4
31

Should be better now (certainly shorter)

shurd updated this revision to Diff 152372.Tue, Mar 18, 12:29 AM
shurd marked an inline comment as done.
  • was->were
Harbormaster completed remote builds in B62951: Diff 152372.Tue, Mar 18, 12:29 AM
shurd updated this revision to Diff 152374.Tue, Mar 18, 12:38 AM
  • Another typo, CPIO -> GPIO
Harbormaster completed remote builds in B62953: Diff 152374.Tue, Mar 18, 12:38 AM
shurd updated this revision to Diff 152375.Tue, Mar 18, 1:08 AM
  • Update .c file per style(9) as well.
Harbormaster completed remote builds in B62954: Diff 152375.Tue, Mar 18, 1:08 AM
shurd updated this revision to Diff 152376.Tue, Mar 18, 1:15 AM
  • Remove unneeded headers
Harbormaster completed remote builds in B62955: Diff 152376.Tue, Mar 18, 1:15 AM
manu accepted this revision.Tue, Mar 18, 7:34 AM
This revision is now accepted and ready to land.Tue, Mar 18, 7:34 AM
Closed by commit rG0832a409c21b: Add driver for the RK3328 GPIO_MUTE pin (authored by shurd). · Explain WhyTue, Mar 18, 5:01 PM
This revision was automatically updated to reflect the committed changes.
shurd added a commit: rG0832a409c21b: Add driver for the RK3328 GPIO_MUTE pin.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
man4.aarch64/
1 line
44 lines
sys/
arm/
rockchip/
1 line
arm64/
rockchip/
236 lines
conf/
1 line

Diff 152394

View Options

share/man/man4/man4.aarch64/Makefile

Loading...
View Options

share/man/man4/man4.aarch64/rk_grf_gpio.4

Loading...
View Options

sys/arm/rockchip/files.rk32xx

Loading...
View Options

sys/arm64/rockchip/rk_grf_gpio.c

Loading...
View Options

sys/conf/files.arm64

Loading...