Page MenuHomeFreeBSD

Add driver for the RK3328 GPIO_MUTE pin
ClosedPublic

Authored by shurd on Mar 17 2025, 9:50 PM.
Tags
None
Referenced Files
F132430027: D49399.id152367.diff
Thu, Oct 16, 9:13 PM
Unknown Object (File)
Sat, Oct 11, 11:26 PM
Unknown Object (File)
Sun, Oct 5, 2:11 PM
Unknown Object (File)
Fri, Oct 3, 1:23 AM
Unknown Object (File)
Wed, Oct 1, 4:18 AM
Unknown Object (File)
Thu, Sep 25, 8:59 AM
Unknown Object (File)
Thu, Sep 18, 2:20 AM
Unknown Object (File)
Sep 11 2025, 3:18 AM
Subscribers

Details

Summary

This is used in in the ROC-RK3328-CC to control a regulator.

Test Plan

Tested on ROC-RK3328-CC board

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

shurd requested review of this revision.Mar 17 2025, 9:50 PM
  • Fix copyright and update wrapping

I don't know what this does, but thank you for writing a manual with it! Some minor style suggestions and questions:

share/man/man4/man4.aarch64/rk_grf_gpio.4
2

The project this - was added for was abandoned

3

You could use SPDX only now if you want, there's an example in style(9)

31

This is more than one line. How's this? The rendered line barely fits on standard console.

38

Does it support the gpio or only the gpio_mute pin?
How can people use it? What does it do? That would be really nice in this section.

41–44
53

I see no reason why we couldn't, but we don't usually say "device driver" lately.

58
shurd added inline comments.
share/man/man4/man4.aarch64/rk_grf_gpio.4
31

Should be better now (certainly shorter)

shurd marked an inline comment as done.
  • was->were
  • Another typo, CPIO -> GPIO
  • Update .c file per style(9) as well.
  • Remove unneeded headers
This revision is now accepted and ready to land.Mar 18 2025, 7:34 AM
This revision was automatically updated to reflect the committed changes.