User Details
- User Since
- Oct 29 2015, 5:25 PM (519 w, 2 d)
- Roles
- Administrator
Thu, Oct 9
Wed, Oct 8
updates to incorporate review feedback
incorporate review feedback; rebase on top of changes to D52946
Reworked patch to use a large-ish buffer allocated from BSS and protected by a lock if called from an interrupt context. As noted in the commit message, this will result in increased lock contention during an interrupt storm which exceeds the capacity of the free list; however, overall lock contention should still be lower than it was when mca_log() was called with the mca_lock held.
Tue, Oct 7
Updating to apply cleanly on top of D52946, which introduces the use of sbuf to gather the log message.
Remove unneeded check for mca_startup_done
Fix logic in case (mode != polled && (mca_startup_done || (rec->mr_status & MC_STATUS_UC)))
Mon, Oct 6
Updated to hide this code under the DIAGNOSTIC kernel config option.
Fri, Oct 3
update diff to account for 8 years of bitrot
AFAIK, no one has bemoaned the lack of this feature in the 8 years this has been sitting here. I think it is safe to abandon this.
Updating the diff to account for 8 years of bit rot.
incorporating review feedback
Thanks for the review! I agree on the documentation comment.
Thu, Oct 2
My main concern about these three revisions is that they are somewhat susceptible of remote manipulation, and that could make it easier to DoS a server. However, I view that as a tradeoff that the user needs to make, and think an appropriate release note should suffice to warn about these issues.
My main concern about these three revisions is that they are somewhat susceptible of remote manipulation, and that could make it easier to DoS a server. However, I view that as a tradeoff that the user needs to make, and think an appropriate release note should suffice to warn about these issues.
Is this worthy of a release note?
If anyone is planning to review this (or if I should ask more people), let me know. Otherwise, I will probably just commit this soon. AFAICT, this is fairly innocuous (new feature with low risk of breaking existing things). But, there is a reason we get these things reviewed...
Thanks for doing this! LGTM other than one nit.
Wed, Oct 1
Mon, Sep 29
Wed, Sep 24
Mon, Sep 15
Fri, Sep 12
May 29 2025
Jun 27 2024
Jun 26 2024
Overall, I think this approach has value. See my in-line comments for suggestions on things to review further.
Jun 21 2024
Thanks! I like this approach. I've added a few comments about potential enhancements.
May 31 2024
Can you give a brief explanation of the problem this is supposed to solve?
May 30 2024
Should we check for TCP_FUNC_BEING_REMOVED?
Dec 20 2023
Dec 19 2023
Nov 17 2023
Nov 16 2023
Nov 7 2023
Oct 30 2023
Sep 15 2023
Jun 1 2023
May 31 2023
May 27 2023
For what its worth...