Page MenuHomeFreeBSD
Differential D52942

x86: Add a way to inject artificial MCA events for testing
ClosedPublic
Actions

Authored by jtl on Mon, Oct 6, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 10:31 PM
Unknown Object (File)
Fri, Oct 10, 10:31 PM
Unknown Object (File)
Fri, Oct 10, 10:31 PM
Unknown Object (File)
Fri, Oct 10, 4:30 PM
Unknown Object (File)
Fri, Oct 10, 10:47 AM
Unknown Object (File)
Thu, Oct 9, 6:21 PM
Unknown Object (File)
Wed, Oct 8, 7:21 PM
Unknown Object (File)
Wed, Oct 8, 4:48 AM
View All 17 Files
Subscribers
imp

Details

Reviewers
glebius
lprylli_netflix.com
markj
jhb
Commits
rG1c2fc62e4a96: x86: Add a way to inject artificial MCA events for testing
Summary

Obtained from Netflix. The code was originally written by Loic Prylli and lightly modified for me as part of upstreaming. Proposed metadata includes "Obtained from" and "Sponsored by" Netflix.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jtl created this revision.Mon, Oct 6, 6:13 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Oct 6, 6:13 PM
jtl requested review of this revision.Mon, Oct 6, 6:13 PM
glebius added a comment.Mon, Oct 6, 6:26 PM

Maybe put that under DIAGNOSTIC or similar hiding ifdef? Only one or two people in the world would ever need this. Those who do, definitely would be compiling kernels.

jtl updated this revision to Diff 163656.Mon, Oct 6, 6:48 PM

Updated to hide this code under the DIAGNOSTIC kernel config option.

jtl added a comment.Mon, Oct 6, 6:49 PM
In D52942#1209601, @jtl wrote:

Updated to hide this code under the DIAGNOSTIC kernel config option.

Good idea! I updated the diff to reflect this.

jtl mentioned this in D52946: x86: Allow MCA messages to be rate-limited.Mon, Oct 6, 9:30 PM
glebius accepted this revision.Tue, Oct 7, 5:43 AM
This revision is now accepted and ready to land.Tue, Oct 7, 5:43 AM
jtl mentioned this in D12278: x86: support sending non-fatal MCA messages to syslog.Tue, Oct 7, 2:38 PM
lprylli_netflix.com accepted this revision.Tue, Oct 7, 4:42 PM
Closed by commit rG1c2fc62e4a96: x86: Add a way to inject artificial MCA events for testing (authored by lprylli_netflix.com, committed by jtl). · Explain WhyTue, Oct 7, 4:43 PM
This revision was automatically updated to reflect the committed changes.
jtl added a commit: rG1c2fc62e4a96: x86: Add a way to inject artificial MCA events for testing.

Revision Contents
Changeset List

PathSize
sys/
x86/
x86/
29 lines

Diff 163709

View Options

sys/x86/x86/mca.c

Loading...