Page MenuHomeFreeBSD
Differential D12275

x86: Defer non-fatal MCA message output from the hardware interrupt context
ClosedPublic
Actions

Authored by jtl on Sep 8 2017, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 4, 10:29 AM
Unknown Object (File)
Sat, Nov 1, 8:23 PM
Unknown Object (File)
Sat, Nov 1, 5:41 AM
Unknown Object (File)
Wed, Oct 29, 3:09 PM
Unknown Object (File)
Wed, Oct 29, 1:38 PM
Unknown Object (File)
Wed, Oct 29, 1:43 AM
Unknown Object (File)
Tue, Oct 28, 10:17 PM
Unknown Object (File)
Tue, Oct 28, 9:36 PM
View All 52 Files
Subscribers
imp

Details

Reviewers
scottl
jhb
markj
glebius
Commits
rG049010b03a98: x86: Defer non-fatal MCA message output from the HW interrupt context
rG3f0df559cbe4: x86: Defer non-fatal MCA message output from the HW interrupt context
rG5e1611a37a02: x86: Defer non-fatal MCA message output from the HW interrupt context
Summary

When processing recoverable MCA events in a hardware interrupt context, defer logging the messages to a task queue.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jtl created this revision.Sep 8 2017, 3:14 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 8 2017, 3:14 PM
jhb accepted this revision.Sep 8 2017, 6:29 PM
This revision is now accepted and ready to land.Sep 8 2017, 6:29 PM
jtl updated this revision to Diff 163482.Oct 3 2025, 6:25 PM
jtl retitled this revision from Defer non-fatal MCA message output from the hardware interrupt context to x86: Defer non-fatal MCA message output from the hardware interrupt context.
jtl edited the summary of this revision. (Show Details)
jtl edited the test plan for this revision. (Show Details)
jtl added reviewers: markj, glebius.
jtl changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

update diff to account for 8 years of bitrot

This revision now requires review to proceed.Oct 3 2025, 6:25 PM
markj accepted this revision.Oct 4 2025, 12:17 PM
markj added inline comments.
sys/x86/x86/mca.c
1142

Perhaps just call mca_process_records(POLLED) directly?

This revision is now accepted and ready to land.Oct 4 2025, 12:17 PM
jtl added inline comments.Oct 6 2025, 4:02 PM
sys/x86/x86/mca.c
1142

That's what I had initially, but I changed it to calling mca_postcan() with the idea that this formulation might be more future proof. Time will tell whether I was right. :-)

Closed by commit rG5e1611a37a02: x86: Defer non-fatal MCA message output from the HW interrupt context (authored by jtl). · Explain WhyOct 6 2025, 4:03 PM
This revision was automatically updated to reflect the committed changes.
jtl added a commit: rG5e1611a37a02: x86: Defer non-fatal MCA message output from the HW interrupt context.
jtl added a commit: rG3f0df559cbe4: x86: Defer non-fatal MCA message output from the HW interrupt context.Thu, Oct 9, 5:17 PM
jtl added a commit: rG049010b03a98: x86: Defer non-fatal MCA message output from the HW interrupt context.Thu, Oct 9, 5:21 PM

Revision Contents
Changeset List

PathSize
sys/
x86/
x86/
41 lines

Diff 163639

View Options

sys/x86/x86/mca.c

Loading...