sockstat: support reporting of BBLog state
ClosedPublic
Actions

Authored by tuexen on Mon, Oct 6, 8:37 PM.

Details

Reviewers

Commits

rGd801cc2d8542: sockstat: support reporting of BBLog state

Summary

Add a -b option to print the BBLog state for TCP sockets.

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

tuexen requested review of this revision.Mon, Oct 6, 8:37 PM

rrs accepted this revision.Tue, Oct 7, 12:28 PM

This revision is now accepted and ready to land.Tue, Oct 7, 12:28 PM

jtl accepted this revision.Tue, Oct 7, 1:14 PM

jtl added inline comments.

usr.bin/sockstat/main.c
1088	It probably is overkill, but you could add a TCP_LOG_STATE_COUNT at the end of `enum tcp_log_states` and add a static assertion that the number hasn't changed. Again, probably overkill.
1529	Why have this conditional? (I recognize it makes it consistent with the treatment of the surrounding options. I'm just curious in understanding why we chose this treatment.)