Paths

Table of Contentst

Differential D52944

sockstat: support reporting of BBLog state
ClosedPublic
Actions

Authored by tuexen on Mon, Oct 6, 8:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 25, 8:11 AM

	Unknown Object (File)
	Fri, Oct 10, 10:47 AM

	Unknown Object (File)
	Fri, Oct 10, 10:47 AM

	Unknown Object (File)
	Fri, Oct 10, 10:47 AM

	Unknown Object (File)
	Fri, Oct 10, 4:14 AM

	Unknown Object (File)
	Fri, Oct 10, 2:35 AM

	Unknown Object (File)
	Tue, Oct 7, 4:09 PM

	Unknown Object (File)
	Tue, Oct 7, 6:56 AM

View All 12 Files

Subscribers

Details

Reviewers

jtl
rrs
rscheff
cc
nickbanks_netflix.com
peter.lei_ieee.org
lstewart

Commits

rGb339da5b23e8: sockstat: support reporting of BBLog state
rGd46d4628f65d: sockstat: support reporting of BBLog state
rGd801cc2d8542: sockstat: support reporting of BBLog state

Summary

Add a -b option to print the BBLog state for TCP sockets.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Mon, Oct 6, 8:37 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptMon, Oct 6, 8:37 PM

tuexen requested review of this revision.Mon, Oct 6, 8:37 PM

rrs accepted this revision.Tue, Oct 7, 12:28 PM

This revision is now accepted and ready to land.Tue, Oct 7, 12:28 PM

jtl accepted this revision.Tue, Oct 7, 1:14 PM

jtl added inline comments.

usr.bin/sockstat/main.c
1088	It probably is overkill, but you could add a TCP_LOG_STATE_COUNT at the end of `enum tcp_log_states` and add a static assertion that the number hasn't changed. Again, probably overkill.
1529	Why have this conditional? (I recognize it makes it consistent with the treatment of the surrounding options. I'm just curious in understanding why we chose this treatment.)

Closed by commit rGd801cc2d8542: sockstat: support reporting of BBLog state (authored by tuexen). · Explain WhyTue, Oct 7, 6:38 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGd801cc2d8542: sockstat: support reporting of BBLog state.

tuexen added a commit: rGd46d4628f65d: sockstat: support reporting of BBLog state.Fri, Oct 10, 11:00 AM

tuexen added a commit: rGb339da5b23e8: sockstat: support reporting of BBLog state.Fri, Oct 10, 11:28 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

sockstat/

55 lines

11 lines

Diff 163661

usr.bin/sockstat/main.c

Loading...

usr.bin/sockstat/sockstat.1

Loading...