tcp: close two minor races with debug messages
ClosedPublic
Actions

Authored by jtl on Thu, Oct 2, 5:33 PM.

Details

Reviewers

tuexen
nickbanks_netflix.com
rrs

Group Reviewers

transport

Commits

rG1cc96642675b: tcp: close two minor races with debug messages
rGa1f20ce89403: tcp: close two minor races with debug messages
rGad38f6a0b466: tcp: close two minor races with debug messages

Summary

The syncache entry is locked by the hash bucket lock. After running
SCH_UNLOCK(), we have no guarantee that that the syncache entry still
exists.

Resolve the race by moving SCH_UNLOCK() after the log() call which
reads variables from the syncache entry.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl created this revision.Thu, Oct 2, 5:33 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptThu, Oct 2, 5:33 PM

jtl requested review of this revision.Thu, Oct 2, 5:33 PM

jtl mentioned this in D52849: tcp: improve segment validation in SYN-RECEIVED.

nickbanks_netflix.com accepted this revision.Thu, Oct 2, 5:43 PM

This revision is now accepted and ready to land.Thu, Oct 2, 5:43 PM

rrs accepted this revision.Thu, Oct 2, 7:23 PM

tuexen accepted this revision.Thu, Oct 2, 7:33 PM

Closed by commit rGad38f6a0b466: tcp: close two minor races with debug messages (authored by jtl). · Explain WhyThu, Oct 2, 8:10 PM

This revision was automatically updated to reflect the committed changes.

jtl added a commit: rGad38f6a0b466: tcp: close two minor races with debug messages.

jtl added a commit: rGa1f20ce89403: tcp: close two minor races with debug messages.Mon, Oct 6, 4:23 PM

jtl added a commit: rG1cc96642675b: tcp: close two minor races with debug messages.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

4 lines

Diff 163385

View Options

sys/netinet/tcp_syncache.c

tcp: close two minor races with debug messagesClosedPublicActions