Page MenuHomeFreeBSD

emaste (Ed Maste)
UserAdministrator

Projects (18)

User Details

User Since
Nov 24 2013, 3:15 AM (620 w, 3 d)
Roles
Administrator

Recent Activity

Today

emaste committed rGac19e85c60ac: Cirrus-CI: Use nproc instead of sysctl -n hw.ncpu (authored by emaste).
Cirrus-CI: Use nproc instead of sysctl -n hw.ncpu
Wed, Oct 15, 1:11 AM
emaste committed rGba89a061d0ba: Cirrus-CI: Switch back to tzst packages, but use level 1 (authored by emaste).
Cirrus-CI: Switch back to tzst packages, but use level 1
Wed, Oct 15, 12:49 AM
emaste committed rG2ef79b0524b5: Cirrus-CI: Build packages in parallel (authored by emaste).
Cirrus-CI: Build packages in parallel
Wed, Oct 15, 12:49 AM
emaste committed rGf283515a1015: Cirrus-CI: Use nproc instead of sysctl -n hw.ncpu (authored by emaste).
Cirrus-CI: Use nproc instead of sysctl -n hw.ncpu
Wed, Oct 15, 12:49 AM
emaste committed rG608043e6d029: Cirrus-CI: Bump to FreeBSD 14.3 image (authored by emaste).
Cirrus-CI: Bump to FreeBSD 14.3 image
Wed, Oct 15, 12:49 AM

Yesterday

emaste requested review of D53106: partedit: limit default swap to maximum supported by kernel.
Tue, Oct 14, 8:35 PM
emaste accepted D42968: freebsd-update: Mention upgrading packages, not just ports.

LGTM

Tue, Oct 14, 7:48 PM
emaste added a comment to D53085: tests/ci: Add reproducibility tests.

I think since NO_ROOT is going to be default this has no more effect on testing. I have already discussed this with @emaste

We should still verify though, root vs non-root should not have an effect but it's possible that "built by <user>" type strings could get included.

Tue, Oct 14, 5:11 PM
emaste added a member for committers: jbo.
Tue, Oct 14, 5:08 PM
emaste added a reverting change for rG676d64ee8327: .cirrus.yml: Reenable CI with pre-commit CI scripts: rGeb895ad4c47e: Revert ".cirrus.yml: Reenable CI with pre-commit CI scripts".
Tue, Oct 14, 3:02 PM
emaste committed rGeb895ad4c47e: Revert ".cirrus.yml: Reenable CI with pre-commit CI scripts" (authored by emaste).
Revert ".cirrus.yml: Reenable CI with pre-commit CI scripts"
Tue, Oct 14, 3:01 PM
emaste added a reverting change for D51178: tests/ci: Add CIENV variable: rGeb895ad4c47e: Revert ".cirrus.yml: Reenable CI with pre-commit CI scripts".
Tue, Oct 14, 3:01 PM
emaste committed rGdbd1e3229643: bsdinstall: Tweak pkgbase/dist set labels (authored by emaste).
bsdinstall: Tweak pkgbase/dist set labels
Tue, Oct 14, 3:01 PM
emaste added inline comments to D52629: libc: Import OpenBSD's inet_net_{ntop,pton}.
Tue, Oct 14, 2:59 PM
emaste accepted D53063: imgact_elf: Check note body sizes.
Tue, Oct 14, 2:07 PM
emaste accepted D53075: Ping: Make build reproducible.
Tue, Oct 14, 12:28 AM

Mon, Oct 13

emaste accepted D53063: imgact_elf: Check note body sizes.
Mon, Oct 13, 2:37 PM
emaste added a comment to D53046: vmimage.subr: Sort METALOG before running makefs.

i feel like this is really an issue in makefs

Mon, Oct 13, 2:13 PM
emaste accepted D53069: libnv: Fix a length check in nvpair_unpack_string_array().
Mon, Oct 13, 2:07 PM
emaste added a comment to D53062: imgact: Mark brandinfo and note structures as const.

Do they get placed in rodata with the change?

Mon, Oct 13, 1:31 PM
emaste accepted D53067: fwget: pci: mediatek: correct package name.
Mon, Oct 13, 1:21 PM
emaste accepted D53062: imgact: Mark brandinfo and note structures as const.

LGTM excluding the accidentally included file. Also I think the commit message ought to reference any changes in ELF sections containing these.

Mon, Oct 13, 1:20 PM

Sun, Oct 12

emaste updated the diff for D53033: zfs: Emit warning upon use of legacy sysctl.

correct mapping per @jlduran

Sun, Oct 12, 1:46 PM
emaste committed rG051c12a5d90a: libcasper: explicit cast in cap_fileargs header (authored by quentin.thebault_defenso.fr).
libcasper: explicit cast in cap_fileargs header
Sun, Oct 12, 12:27 AM
emaste committed rG998dd4a11a2b: libcasper: explicit cast in cap_fileargs header (authored by quentin.thebault_defenso.fr).
libcasper: explicit cast in cap_fileargs header
Sun, Oct 12, 12:26 AM

Sat, Oct 11

emaste updated subscribers of D53033: zfs: Emit warning upon use of legacy sysctl.
Sat, Oct 11, 6:32 PM
emaste committed rGabd9424590ba: bsdinstall: Tweak pkgbase/dist set labels (authored by emaste).
bsdinstall: Tweak pkgbase/dist set labels
Sat, Oct 11, 5:23 PM
emaste closed D52999: bsdinstall: Describe pkgbase as "Tech Preview".
Sat, Oct 11, 5:23 PM

Fri, Oct 10

emaste added inline comments to D53033: zfs: Emit warning upon use of legacy sysctl.
Fri, Oct 10, 11:41 PM
emaste requested review of D53033: zfs: Emit warning upon use of legacy sysctl.
Fri, Oct 10, 8:46 PM
emaste added a comment to D53023: libm: remainder: make sure x is zero.

Will do. I tried to add him to the review before uploading the patch but couldn't find an account.

Fri, Oct 10, 6:58 PM
emaste accepted D53016: libbluetooth: Move to the bluetooth-lib package.
Fri, Oct 10, 1:47 PM
emaste accepted D53020: audio/sndio: Add virtual_oss to rcorder.
Fri, Oct 10, 1:07 PM
emaste accepted D53019: virtual_oss: Clean up rcorder.
Fri, Oct 10, 1:05 PM
emaste added a comment to D52999: bsdinstall: Describe pkgbase as "Tech Preview".
┌────────────┤Select Installation Type├─────────────┐
│ Would you like to install the base system using   │  
│ traditional distribution sets or packages         │  
│ (technology preview)?                             │  
├───────────────────────────────────────────────────┤  
│[   Distribution Sets   ] [Packages (Tech Preview)]│  
└───────────────────────────────────────────────────┘
Fri, Oct 10, 12:55 PM
emaste updated the diff for D52999: bsdinstall: Describe pkgbase as "Tech Preview".

update button label

Fri, Oct 10, 12:54 PM

Thu, Oct 9

emaste committed rG349da4dbff72: libcasper: explicit cast in cap_fileargs header (authored by quentin.thebault_defenso.fr).
libcasper: explicit cast in cap_fileargs header
Thu, Oct 9, 5:53 PM
emaste requested review of D53000: GitHub: Use parens for hashes listed by checklist.
Thu, Oct 9, 5:17 PM
emaste updated the diff for D52999: bsdinstall: Describe pkgbase as "Tech Preview".

Update description as well

Thu, Oct 9, 5:08 PM
emaste requested review of D52999: bsdinstall: Describe pkgbase as "Tech Preview".
Thu, Oct 9, 5:06 PM
emaste added a comment to D52665: UPDATING: Add entry for boot-time error message caused by removal of vfs.zfs.min_auto_ashift tunable.

I would phrase this slightly differently -- bsdinstall now uses the updated name, and with the revert I just committed the "unknown oid" will go away. We should mention that the sysctl OIDs changed with the switch to OpenZFS in FreeBSD 13 and backwards compatibility will be removed. It's a little tricky because this should have been an UPDATING entry many years ago.

Thu, Oct 9, 3:32 PM
emaste added a reverting change for rGced72fdd69f2: tunables: remove legacy FreeBSD aliases: rGa28b44ddc348: zfs: Revert "tunables: remove legacy FreeBSD aliases".
Thu, Oct 9, 2:47 PM
emaste committed rGa28b44ddc348: zfs: Revert "tunables: remove legacy FreeBSD aliases" (authored by emaste).
zfs: Revert "tunables: remove legacy FreeBSD aliases"
Thu, Oct 9, 2:47 PM
emaste closed D52660: OpenZFS: Revert "tunables: remove legacy FreeBSD aliases".
Thu, Oct 9, 2:47 PM
emaste accepted D52987: release: Don't install lib32 into riscv64 VMs.
Thu, Oct 9, 2:33 PM

Wed, Oct 8

emaste added a comment to D52869: MFV: blocklist (8aa81bf).

What can/should we do to handle the blacklistd.conf -> blocklistd.conf transition?

Wed, Oct 8, 2:12 PM
emaste accepted D52972: release: Fix dependency ordering.
Wed, Oct 8, 12:32 AM

Tue, Oct 7

emaste updated subscribers of D52972: release: Fix dependency ordering.
Tue, Oct 7, 11:18 PM
emaste committed rGe01971362fe6: Merge commit 7a66a26658f4 from llvm git (by Fangrui Song): (authored by emaste).
Merge commit 7a66a26658f4 from llvm git (by Fangrui Song):
Tue, Oct 7, 6:18 PM
emaste committed rG5c0d60e75b44: boot_i386.8: Mention this is legacy (authored by emaste).
boot_i386.8: Mention this is legacy
Tue, Oct 7, 6:18 PM
emaste committed rG244ecc561601: Makefile.inc1: Avoid including cwd in path (authored by emaste).
Makefile.inc1: Avoid including cwd in path
Tue, Oct 7, 6:17 PM
emaste committed rGf5936037f2f1: Cirrus-CI: Bump to FreeBSD 14.3 image (authored by emaste).
Cirrus-CI: Bump to FreeBSD 14.3 image
Tue, Oct 7, 6:17 PM
emaste accepted D52933: cross-build: Define __GNUC_PREREQ__ in cdefs.h.
Tue, Oct 7, 3:02 PM

Mon, Oct 6

emaste added a comment to D52933: cross-build: Define __GNUC_PREREQ__ in cdefs.h.

Seems OK, although I wonder if __has_builtin(__builtin_add_overflow) will be true on GCC versions that are still relevant (and we could remove the __GNUC_PREREQ__ from stdckdint.h

Mon, Oct 6, 3:47 PM
emaste accepted D52932: tools/build: Bring in stdckdint.h if needed.
Mon, Oct 6, 3:44 PM
emaste added a comment to D52879: Makefile: Don't allow install{world,kernel} with pkgbase.

not sure if the FreeBSD user community is ready for this yet

Mon, Oct 6, 1:10 PM
emaste committed rG6409980cbba7: Vendor import of OpenSSH 10.1p1 (authored by emaste).
Vendor import of OpenSSH 10.1p1
Mon, Oct 6, 1:00 PM

Sat, Oct 4

emaste accepted D52728: pci: add quirk to disable FLR.
Sat, Oct 4, 6:10 PM
emaste accepted D52902: Makefile.inc1: Fix package-pkg with CROSS_TOOLCHAIN.
Sat, Oct 4, 4:13 PM
emaste committed rGcca9295dd6ad: Cirrus-CI: Bump to FreeBSD 14.3 image (authored by emaste).
Cirrus-CI: Bump to FreeBSD 14.3 image
Sat, Oct 4, 4:10 PM
emaste committed rGbc4a85b69dea: Cirrus-CI: Bump to FreeBSD 13.5 image (authored by emaste).
Cirrus-CI: Bump to FreeBSD 13.5 image
Sat, Oct 4, 4:09 PM
emaste committed rGa7931987d609: usbhid.4: Note that it was enabled by default for 15.0 (authored by emaste).
usbhid.4: Note that it was enabled by default for 15.0
Sat, Oct 4, 1:38 PM
emaste accepted D52901: release: Set INSTALL_AS_USER=yes when running pkg clean in NO_ROOT mode.
Sat, Oct 4, 1:01 PM
emaste accepted D52881: generate-ucl.lua: Add missing copyright header.
Sat, Oct 4, 12:10 AM

Fri, Oct 3

emaste closed D52895: bsd.port.mk: Spell .export-env correctly.
Fri, Oct 3, 11:00 PM
emaste committed R11:5b55c88bc4eb: bsd.port.mk: Spell .export-env correctly (authored by emaste).
bsd.port.mk: Spell .export-env correctly
Fri, Oct 3, 11:00 PM
emaste requested review of D52895: bsd.port.mk: Spell .export-env correctly.
Fri, Oct 3, 8:53 PM
emaste committed rGa8d774d9708c: man: Conditionally install ar.5 in toolchain package (authored by emaste).
man: Conditionally install ar.5 in toolchain package
Fri, Oct 3, 5:20 PM
emaste closed D52886: man: Conditionally install ar.5 in toolchain package.
Fri, Oct 3, 5:20 PM
emaste accepted D52820: arch.7: deprecate __ILP32__ and __LP64__ macros.
Fri, Oct 3, 4:16 PM
emaste requested review of D52886: man: Conditionally install ar.5 in toolchain package.
Fri, Oct 3, 4:05 PM
emaste committed rGae5914c0e447: Cirrus-CI: Switch back to tzst packages, but use level 1 (authored by emaste).
Cirrus-CI: Switch back to tzst packages, but use level 1
Fri, Oct 3, 3:13 PM
emaste closed D52858: Cirrus-CI: Switch back to tzst packages, but use level 1.
Fri, Oct 3, 3:13 PM
emaste accepted D52822: arch.7: Add CHERI architectures.
Fri, Oct 3, 3:06 PM
emaste added a comment to D52820: arch.7: deprecate __ILP32__ and __LP64__ macros.

Latest update doesn't seem to include the mentioned change.

Fri, Oct 3, 2:53 PM
emaste committed rGac1408bd1d2d: release: Consolidate pkgbase-repo dependency (authored by emaste).
release: Consolidate pkgbase-repo dependency
Fri, Oct 3, 2:31 PM
emaste closed D52884: release: Consolidate pkgbase-repo-dir dependency.
Fri, Oct 3, 2:31 PM
emaste committed rG65e2ce55b662: vmimage.subr: fix typo in checking NO_ROOT var (authored by guest-svmhdvn).
vmimage.subr: fix typo in checking NO_ROOT var
Fri, Oct 3, 2:24 PM
emaste added a comment to D52881: generate-ucl.lua: Add missing copyright header.

Oh, yeah - I didn't look at the extent of the various contributions. I wouldn't have added a FF copyright for @ifreund_freebsdfoundation.org's contribution either; IMO just @bapt and @ivy.

Fri, Oct 3, 12:49 PM
emaste updated the diff for D52884: release: Consolidate pkgbase-repo-dir dependency.

Add bootonly as well, which gained the dependency after I originally made this change

Fri, Oct 3, 12:40 PM
emaste added a comment to D34547: bhyve - snapshot capsicum integration[Part 1].

Capsicum+snapshot support arrived via D38858 and D38860.

Fri, Oct 3, 12:36 PM
emaste requested review of D52884: release: Consolidate pkgbase-repo-dir dependency.
Fri, Oct 3, 11:16 AM
emaste requested review of D52883: pkg-stage: Invoke ln with -f.
Fri, Oct 3, 11:12 AM
emaste accepted D52881: generate-ucl.lua: Add missing copyright header.

OK on behalf of the FreeBSD Foundation. I agree with @imp wrt dropping the license text.

Fri, Oct 3, 10:57 AM
emaste accepted D52877: Makefile: Fix ordering for (update-)packages.
Fri, Oct 3, 2:58 AM
emaste committed rG5c5c0571c298: release: Fix NO_ROOT cross-building VM images (authored by emaste).
release: Fix NO_ROOT cross-building VM images
Fri, Oct 3, 12:31 AM
emaste closed D52874: release: Fix NO_ROOT cross-building VM images.
Fri, Oct 3, 12:31 AM
emaste updated the diff for D52874: release: Fix NO_ROOT cross-building VM images.

Move PKG_ABI setting earlier

Fri, Oct 3, 12:20 AM

Thu, Oct 2

emaste updated the diff for D52874: release: Fix NO_ROOT cross-building VM images.

another spot to plumb ABI through, from @markj

Thu, Oct 2, 11:33 PM
emaste updated the diff for D52874: release: Fix NO_ROOT cross-building VM images.

typo

Thu, Oct 2, 10:41 PM
emaste added inline comments to D52874: release: Fix NO_ROOT cross-building VM images.
Thu, Oct 2, 10:40 PM
emaste updated the diff for D52874: release: Fix NO_ROOT cross-building VM images.

add one case noted by mark and one more pkg invocation

Thu, Oct 2, 10:38 PM
emaste requested review of D52874: release: Fix NO_ROOT cross-building VM images.
Thu, Oct 2, 10:09 PM
emaste committed rG44f3e9f7f6c9: usbhid.4: Note where debug messages go (authored by emaste).
usbhid.4: Note where debug messages go
Thu, Oct 2, 4:52 PM
emaste committed rG2acabc7318ac: hkbd: remove error detection in KDSKBSTATE ioctl (authored by aokblast).
hkbd: remove error detection in KDSKBSTATE ioctl
Thu, Oct 2, 4:42 PM
emaste accepted D52681: mfc-candidates: Minor improvements.
Thu, Oct 2, 4:31 PM
emaste committed rG7b18bf2a225a: usbhid.4: Note that it was enabled by default for 15.0 (authored by emaste).
usbhid.4: Note that it was enabled by default for 15.0
Thu, Oct 2, 4:18 PM
emaste added inline comments to D52862: thunderbolt: Pink Sardine support.
Thu, Oct 2, 3:54 PM
emaste updated subscribers of D52858: Cirrus-CI: Switch back to tzst packages, but use level 1.

@cperciva: @ivy wondered if we could make the default to be lower compression (level 1 or whatever the best tradeoff between speed and size is) and have the official release builds set it to some high level. I think that's reasonable in principle, but I want the release artifacts to be reproducible without requiring users to set a variety of build knobs. What do you think about having one top-level knob to set for official release builds that controls the various defaults for things like this?

Thu, Oct 2, 3:49 PM
emaste committed rGe2796f0359af: Cirrus-CI: Build packages in parallel (authored by emaste).
Cirrus-CI: Build packages in parallel
Thu, Oct 2, 3:36 PM