User Details
- User Since
- Nov 24 2013, 3:15 AM (620 w, 3 d)
- Roles
- Administrator
Today
Yesterday
LGTM
We should still verify though, root vs non-root should not have an effect but it's possible that "built by <user>" type strings could get included.
Mon, Oct 13
i feel like this is really an issue in makefs
Do they get placed in rodata with the change?
LGTM excluding the accidentally included file. Also I think the commit message ought to reference any changes in ELF sections containing these.
Sun, Oct 12
correct mapping per @jlduran
Sat, Oct 11
Fri, Oct 10
Will do. I tried to add him to the review before uploading the patch but couldn't find an account.
┌────────────┤Select Installation Type├─────────────┐ │ Would you like to install the base system using │ │ traditional distribution sets or packages │ │ (technology preview)? │ ├───────────────────────────────────────────────────┤ │[ Distribution Sets ] [Packages (Tech Preview)]│ └───────────────────────────────────────────────────┘
update button label
Thu, Oct 9
Update description as well
I would phrase this slightly differently -- bsdinstall now uses the updated name, and with the revert I just committed the "unknown oid" will go away. We should mention that the sysctl OIDs changed with the switch to OpenZFS in FreeBSD 13 and backwards compatibility will be removed. It's a little tricky because this should have been an UPDATING entry many years ago.
Wed, Oct 8
What can/should we do to handle the blacklistd.conf -> blocklistd.conf transition?
Tue, Oct 7
Mon, Oct 6
Seems OK, although I wonder if __has_builtin(__builtin_add_overflow) will be true on GCC versions that are still relevant (and we could remove the __GNUC_PREREQ__ from stdckdint.h
not sure if the FreeBSD user community is ready for this yet
Sat, Oct 4
Fri, Oct 3
Latest update doesn't seem to include the mentioned change.
Oh, yeah - I didn't look at the extent of the various contributions. I wouldn't have added a FF copyright for @ifreund_freebsdfoundation.org's contribution either; IMO just @bapt and @ivy.
Add bootonly as well, which gained the dependency after I originally made this change
OK on behalf of the FreeBSD Foundation. I agree with @imp wrt dropping the license text.
Move PKG_ABI setting earlier
Thu, Oct 2
another spot to plumb ABI through, from @markj
typo
add one case noted by mark and one more pkg invocation
@cperciva: @ivy wondered if we could make the default to be lower compression (level 1 or whatever the best tradeoff between speed and size is) and have the official release builds set it to some high level. I think that's reasonable in principle, but I want the release artifacts to be reproducible without requiring users to set a variety of build knobs. What do you think about having one top-level knob to set for official release builds that controls the various defaults for things like this?