Poudriere's test suite has more testing of this timeout and SIGALRM. It checks for timeout adjusting on [EINTR] and ensuring timeout runs within the period specified. If you want to try that you'll need to modify external/sh/miscbltin.c with the patch and then use make checkquick. Or I can check on the next patch.

We have a lot of different styles in use, and I think this one is a violation of the consistency patterns in the manual as a whole. I gave a talk about it at BSDCan '25. Here's a link youtu.be/RthIOXpwwsM

Yeah I read the if as a while and forgot that FreeBSD does not update tv when select() is interrupted. I'll work on this some more.

Looks like I forgot to put a Differential Revision: tag on that commit.

kaizen I guess

@aly_aaronly.me please don't re-open a review to report an issue, since it won't have the desired effect and just adds confusion. It looks like the text was changed here and the GitHub pull request has been merged and I think there's nothing more to do.

Hmmm, I wonder if what might be better is to rework the existing apm.4 manpage to say it is an interface (instead of a driver), but not merge all its content over into acpi.4. It's more that this is a way to describe an API than a device driver. There would be no real SYNOPSIS in this case in the classic sense (we don't really have a model for a SYNOPSIS for something that is an abstract interface as opposed to a foo.ko you can load). That is, you would take the existing apm.4, and make the following changes:

I would love this. This change should probably also revert the commit I just made to strip "device iwx" from iwx.4 synopsis so it's atomic.

Hadn't noticed this new revision (Phabricator mail sending seems to be delayed), so reposting the relevant part of the comment I added on D47878 in the meantime:

In D47878#1227393, @jhb wrote:

The memcpy size is wrong.