Page MenuHomeFreeBSD

Recent Activity

Today

emaste requested review of D61513: nuageinit: Split pw line on :s.
Fri, Nov 13, 4:42 PM
imp accepted D61418: msdosfs: bound slot offset in mbnambuf_write().

This looks good... but it might be good to have at least a reference FAT image with the mal-formed LFN entry for regression.

Fri, Nov 13, 4:39 PM
tuexen accepted D61509: ip6_forward: Free the ICMPv6 copy on all error paths.
Fri, Nov 13, 4:38 PM
tuexen added a reviewer for D61509: ip6_forward: Free the ICMPv6 copy on all error paths: msvoelker.
Fri, Nov 13, 4:30 PM
bcr added a comment to D61507: UPDATING: note login-name validation in pw(8)/pwd_mkdb(8).

Some typo fixes, nothing major.

Fri, Nov 13, 4:25 PM
jhibbits accepted D60837: powerpc: don't drop FPU and VMX ownership in grab_mcontext().
Fri, Nov 13, 4:20 PM
emaste requested review of D61511: nuageinit: Skip ssh keys if default user adduser fails.
Fri, Nov 13, 4:15 PM
ngie added inline comments to D61482: asmc: do not drop shutdown notification when the system node fails.
Fri, Nov 13, 4:09 PM
sarah.walker2_arm.com updated the diff for D61391: sys/arm64: Add ttl parameter to pmap_invalidate_range().

Address review comments

Fri, Nov 13, 4:07 PM
emaste closed D61158: ure: Initialize ifm_active in ure_ifmedia_sts.
Fri, Nov 13, 4:06 PM
emaste committed rG83067a22396f: ure: Initialize ifm_active in ure_ifmedia_sts.
Fri, Nov 13, 4:06 PM
anascime_amd.com added a comment to D61449: hwpmc: Fix use-after-free races between PMC release and context switches.

I thought about reordering the functions, but I didn't want to tinker with them much considering that I am still learning about hwpmc. Reordering could bring newer issues that I couldn't foresee immediately. Even though this is a big hammer, the second-order effects seem to me to be better understood. Also, reordering alone wouldn't close the switch-in race: pmc_process_csw_in() takes the PMC pointer from the process's table without holding a reference, so a release could free the PMC before the runcount increment, whatever the order. Some kind of grace period or locking would still be needed.

Fri, Nov 13, 4:04 PM
alven closed D60159: cad/ldview: Update 4.6 => 4.7, switch Qt 5 => 6.
Fri, Nov 13, 4:03 PM
alven committed R11:efe06d5decde: cad/ldview: Update 4.6 => 4.7, switch Qt 5 => 6.
Fri, Nov 13, 4:03 PM
ngie accepted D61482: asmc: do not drop shutdown notification when the system node fails.
Fri, Nov 13, 4:02 PM
olce added inline comments to D61448: sched_ule: Fix rare deadlock on stealing a migrated lock-blocked thread.
Fri, Nov 13, 4:00 PM
markj requested review of D61510: procctl: Zero the output structure for the compat32 syscall.
Fri, Nov 13, 3:58 PM
jlduran added a comment to D61437: openssh: tests: Revert _PATH_LOCALBASE usage.
In D61437#1409130, @se wrote:

The patch to use _PATH_LOCALBASE should not have been applied to contrib software that has been imported verbatim.
Therefore, the src/contrib directory (and src/sys/contrib etc.) had been excluded, but the fact that other such files exist below src/crypto had been missed.

Fri, Nov 13, 3:57 PM
hayzam_gmail.com updated the diff for D61495: vmm: Route MMIO-to-MMIO MOVS by GPA.

Address review

Fri, Nov 13, 3:55 PM
emaste closed D61441: nuageinit; Skip SSH keys and doas/sudo if adduser fails.
Fri, Nov 13, 3:55 PM
emaste committed rGd9fa6016011e: nuageinit; Skip SSH keys and doas/sudo if adduser fails.
Fri, Nov 13, 3:55 PM
emaste closed D61412: sched_*(2), rtprio*(2): Add capability mode checks.
Fri, Nov 13, 3:52 PM
emaste committed rG1947932d6f4f: capsicum: Add tests for sched_* and rtprio* (authored by ojanerif_amd.com).
Fri, Nov 13, 3:52 PM
yuri accepted D60159: cad/ldview: Update 4.6 => 4.7, switch Qt 5 => 6.

LGTM

Fri, Nov 13, 3:49 PM
brooks committed rG143da26632a9: kern_revoke: remove always UIO_USERSPACE pathseg argument.
Fri, Nov 13, 3:39 PM
markj added a comment to D61498: bhyve: Preserve upper RAX bits for byte and word input.

Does emulate_inout_port() in the kernel need the same change?

Fri, Nov 13, 3:36 PM
adrian added a comment to D61449: hwpmc: Fix use-after-free races between PMC release and context switches.

Hm, now that I'm looking at it .. is there really no way to make the pmc_process_csw_in() / pmc_process_csw_out() routines order things in a way that would avoid this?
I don't mind using a big hammer like this right now if there's no neater semantics to fix the refcount vs PMC alloc/dealloc logic, but I do wonder if some better lifecycle definition would make this less costly.

Fri, Nov 13, 3:34 PM
markj accepted D61495: vmm: Route MMIO-to-MMIO MOVS by GPA.
Fri, Nov 13, 3:28 PM
ehaupt committed R11:54d42e4d3103: audio/shairport-sync: Update to 5.6.3.
Fri, Nov 13, 3:26 PM
ehaupt committed R11:08aaeac0fd76: x11-fonts/font-manager: Update to 0.9.6.
Fri, Nov 13, 3:26 PM
jrm accepted D61500: net/stu: New port: TUI explorer for Amazon S3 and compatible object storage.

Looks good. Another nit: Let's drop the emoji from the commit message.

Fri, Nov 13, 3:26 PM
osa committed R11:79d833460925: databases/kividb: update: 1.2.0 -> 1.2.2.
Fri, Nov 13, 3:22 PM
mchoo added a comment to D61448: sched_ule: Fix rare deadlock on stealing a migrated lock-blocked thread.

A short note on the commit message: Usually in commit message I only put 1) what is the problem, 2) how to solve it, 3) if it's hard to explain in theory, what's an example and I think this deserves having 3). Meanwhile, I think how we got here part (paragraph on initial approach) and how it was reported can be replaced by Differential Revision: and the mailing list thread (Reported by: avg@ <link>) respectively. Then 1), 2), 3) can be more consolidated (I asked LLM to rephrase the commit message and it gave me one shorter and easier to understand). There are few reasons I want to keep commit message concise, one of them is because I don't want my commit message to take too much space when others are scrolling git log.

Fri, Nov 13, 3:18 PM
jrm retitled D61429: */tex*: Update to TeX Live 2026 (20260301) from */tex*: Update to version TeX Live 2026 (20260301)
Fri, Nov 13, 3:17 PM
yuri accepted D61500: net/stu: New port: TUI explorer for Amazon S3 and compatible object storage.

LGTM

Fri, Nov 13, 3:17 PM
yuri committed R11:9bbde209e2d0: audio/sonivox-eas: update 1.7.0 → 1.7.1.
Fri, Nov 13, 3:12 PM
yuri committed R11:8c94b5d057df: misc/ncnn: fix plist.
Fri, Nov 13, 3:12 PM
yuri committed R11:53f0ae2a873d: audio/gsequencer: update 9.3.4 → 9.4.8.
Fri, Nov 13, 3:12 PM
rcm requested review of D61509: ip6_forward: Free the ICMPv6 copy on all error paths.
Fri, Nov 13, 3:06 PM
mchoo accepted D61448: sched_ule: Fix rare deadlock on stealing a migrated lock-blocked thread.

Yes, I like this solution more than fixing in stealing code path.

Fri, Nov 13, 3:06 PM