Does that mean that we'll see another few changes like this making more stats public?
Address some feedback.
Thanks for taking a look.
Im not sure whether it is a good idea to execute all the commands silenty during build -- I would probably prefer to remove the '@'.
This change does more than advertised in the CR description.
What else in the kernel wants to have access to this information?
Nothing yet. NetApp has a module that aggregates stats from various protocols, so that's where this patch is coming from. It would seem that a read-only copy is enough for this use-case, if that's your concern.
I was mostly just wondering. If I'd noticed the inverse (i.e. V_igmpstat is in the header but used nowhere else) I'd be inclined to reverse that. Generally you want as little visibility for your data as possible.
It may be worth adding a comment here to explain why it's in the header.
I think this change is fine as is.
I'm still in doubt about the usefulness of LOCALBASE being specified at run-time if it is not applied to all paths in the system.
And for all other cases (not changed at run-time) a compiled in _PATH_LOCALBASE works as well, while scripts can use the sysctl command.