Page MenuHomeFreeBSD

Recent Activity

Today

jamie committed rG086e0149ae56: jail: Use re-entrant versions of lex & yacc, and lex's yylineno (authored by jamie).
jail: Use re-entrant versions of lex & yacc, and lex's yylineno
Sun, Jun 4, 3:08 AM
markj closed D39783: ossl: Add a VAES-based AES-GCM implementation for amd64.
Sun, Jun 4, 1:48 AM
wen committed R11:3e792e0ff70f: math/R-cran-mvtnorm: Update to 1.2.0 (authored by wen).
math/R-cran-mvtnorm: Update to 1.2.0
Sun, Jun 4, 1:04 AM
wen committed R11:91ea7ed3c46d: devel/thonny: Update to 4.1.0 (authored by wen).
devel/thonny: Update to 4.1.0
Sun, Jun 4, 1:04 AM
wen committed R11:93125267f53c: astro/py-sunpy: Update to 4.1.7 (authored by wen).
astro/py-sunpy: Update to 4.1.7
Sun, Jun 4, 1:04 AM
wen committed R11:99024a1e8693: astro/p5-Astro-SpaceTrack: Update to 0.162 (authored by wen).
astro/p5-Astro-SpaceTrack: Update to 0.162
Sun, Jun 4, 1:04 AM
wen committed R11:8280e6c40ea1: devel/p5-CPU-Z80-Assembler: Update to 2.25 (authored by wen).
devel/p5-CPU-Z80-Assembler: Update to 2.25
Sun, Jun 4, 1:04 AM
jamie committed rG097db30a8e03: jail: Allow nested jail definitions. (authored by jamie).
jail: Allow nested jail definitions.
Sun, Jun 4, 12:47 AM
ihor_antonovs.family resigned from D39011: Enable jail(8) to parse all config files.

IMHO this is superseded by https://reviews.freebsd.org/D40188

Sun, Jun 4, 12:34 AM
ihor_antonovs.family resigned from D38826: Fix multiple rc.d/jail and jail.conf.d issues.

IMHO this is superseded by https://reviews.freebsd.org/D40188

Sun, Jun 4, 12:34 AM · Jails
s199p.wa1k9r_gmail.com added a comment to D40407: Fix broken UART console output on RK356x in ACPI mode.
In D40407#920099, @imp wrote:

So why does this fix things? Otherwise, looks like it's OK

Sun, Jun 4, 12:26 AM · Contributor Reviews (src)

Yesterday

wen committed R11:e9a7d03356d7: science/py-DendroPy: Update to 4.6.0 (authored by wen).
science/py-DendroPy: Update to 4.6.0
Sat, Jun 3, 11:15 PM
wen committed R11:a5d9499c055a: devel/p5-Sub-Quote: Add missing DEPENDS (authored by wen).
devel/p5-Sub-Quote: Add missing DEPENDS
Sat, Jun 3, 11:15 PM
daniel_octaforge.org added a comment to D40413: sh(1): initialize smark to zero in main().

proper patch: https://reviews.freebsd.org/D40415

Sat, Jun 3, 10:45 PM
daniel_octaforge.org requested review of D40415: sh(1): make smark a static variable instead of a local in main().
Sat, Jun 3, 10:44 PM
daniel_octaforge.org added a comment to D40413: sh(1): initialize smark to zero in main().

Now that I am thinking about it, this may not be a compiler issue - the C standard specifies that the value of non-volatile local variables modified between the setjmp call and the longjmp is unspecified. So making these static is actually the right way to go.

Sat, Jun 3, 10:35 PM
ashish committed R11:8021dddb01d5: textproc/quickwit: add port (authored by ashish).
textproc/quickwit: add port
Sat, Jun 3, 10:29 PM
daniel_octaforge.org added a comment to D40413: sh(1): initialize smark to zero in main().

This patch actually works around the problem:

Sat, Jun 3, 10:24 PM
cperciva updated the diff for D40327: Annotate parts of SYSINIT cpu with tslog.

Add missing TSEXIT

Sat, Jun 3, 10:21 PM
daniel_octaforge.org added a comment to D40413: sh(1): initialize smark to zero in main().

and indeed, further testing reveals that the issue does not get fixed by this change (nor by moving setstackmark), only hidden; any changes to smark contents are *not* visible after the jump, which in practice means we are most likely leaking memory, or worse

Sat, Jun 3, 10:14 PM
daniel_octaforge.org added a comment to D40413: sh(1): initialize smark to zero in main().

@jilles I looked into this more and it seems that this is actually a miscompilation, possibly caused by the LLVM optimizer getting confused because of the long jumps.

Sat, Jun 3, 9:46 PM
kib accepted D40410: xregs_sig: Add a ability to handle multiple register banks.
Sat, Jun 3, 9:24 PM
dchagin updated the diff for D40410: xregs_sig: Add a ability to handle multiple register banks.

whoops, missed it due to phabric email doesn't show it,
constify struct xregs_banks, thank you

Sat, Jun 3, 9:14 PM
bapt committed rGfa6fa98ac712: sh(1): initialize smark to zero in main() (authored by Daniel Kolesa <q66@chimera-linux.org>).
sh(1): initialize smark to zero in main()
Sat, Jun 3, 9:11 PM
bapt closed D40413: sh(1): initialize smark to zero in main().
Sat, Jun 3, 9:10 PM
bapt added a comment to D40413: sh(1): initialize smark to zero in main().

<@q66> bapt: anyway, to reproduce: i added this to memalloc.c https://gist.github.com/q66/978ca271db9ea32c8641209eb90f2f85
<@q66> then all you have to do is exec the sh binary, and press ctrl-c
<@q66> in plain prompt
<@q66> https://gist.github.com/q66/99295f340eeaffae740d53e0cc603ad0
<@q66> actually, printf("POPSTACKMARK %p %p\n", mark->stackp, stackp); is more explanatory
<@q66> you will see a POPSTACKMARK 0 0 upon ctrl-c
<@q66> e.g. like https://gist.github.com/q66/61b70ecabb510bbdf86a11e330f89893
<@q66> if i compile without the zeroing
<@q66> i will get a bogus address
<@q66> in mark->stackp

Sat, Jun 3, 9:08 PM
imp accepted D40244: efi: Update efi_phys_to_kva to accept the size of the object being mapped..
Sat, Jun 3, 9:02 PM
imp added a comment to D39971: it8613hwm(4): add man page.

Since the docs people have said OK, I'll commit this once D39970 is ready... and you certify that this adds nothing to the igor or mandoc -T lint output.

Sat, Jun 3, 9:00 PM
imp added a comment to D39970: it8613hwm(4): Add new driver for ITE IT8613 hardware monitor.

style?

Sat, Jun 3, 8:58 PM
kib added inline comments to D40410: xregs_sig: Add a ability to handle multiple register banks.
Sat, Jun 3, 8:56 PM
bapt added a comment to D40413: sh(1): initialize smark to zero in main().

the issue was caught by the author of chimera linux when compiling it with lto and clang16

Sat, Jun 3, 8:55 PM
db committed R11:c0b73f79c65c: comms/gpredict: Fixed missing depends (authored by db).
comms/gpredict: Fixed missing depends
Sat, Jun 3, 8:51 PM
jilles added a comment to D40413: sh(1): initialize smark to zero in main().

To me, it looks like that situation can't actually happen. If there is an error or SIGINT during early initialization, state will still be 0 and the if (setjmp(main_handler.loc)) block will immediately call exitshell(exitstatus) without touching smark. If I'm wrong, please provide a reproduction scenario.

Sat, Jun 3, 8:51 PM
imp accepted D40413: sh(1): initialize smark to zero in main().
Sat, Jun 3, 8:49 PM
imp added a comment to D40407: Fix broken UART console output on RK356x in ACPI mode.

So why does this fix things? Otherwise, looks like it's OK

Sat, Jun 3, 8:41 PM · Contributor Reviews (src)
christos requested review of D40414: dtrace: move kinst tests to common.
Sat, Jun 3, 8:33 PM
imp committed rGb4dd6e1a2837: ports(7): '*-list' targets: Add/fix doc on whether they are recursive (authored by olce.freebsd_certner.fr).
ports(7): '*-list' targets: Add/fix doc on whether they are recursive
Sat, Jun 3, 8:29 PM
bapt requested review of D40413: sh(1): initialize smark to zero in main().
Sat, Jun 3, 8:19 PM
bofh committed R11:386e791e43df: devel/libzim: Update version 6.3.2=>8.2.0 (authored by olce.freebsd_certner.fr).
devel/libzim: Update version 6.3.2=>8.2.0
Sat, Jun 3, 8:18 PM
bofh committed R11:aeb0a1d7f144: sysutils/tmate: Add BACKSPACE option (authored by yasu).
sysutils/tmate: Add BACKSPACE option
Sat, Jun 3, 8:18 PM