In D37356#848742, @corvink wrote:You've just renamed the variable and inverted the logic from is_set to is_setable. That's unneccessary. Please keep the old name.
The only thing which really changed is that the reset of the variable is done in nvme_init_queues instead of nvme_reset.
So, the question is: Do we have to reset the variable on nvme_reset. I don't know. Your quote of the specification isn't clear on that.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 17 2022
Nov 17 2022
wanpengqian_gmail.com added inline comments to D37356: bhyve: fix the number of queue feature setting timing for nvme controller..
Nov 14 2022
Nov 14 2022
wanpengqian_gmail.com added inline comments to D37356: bhyve: fix the number of queue feature setting timing for nvme controller..
Nov 11 2022
Nov 11 2022
wanpengqian_gmail.com added a comment to D37356: bhyve: fix the number of queue feature setting timing for nvme controller..
wanpengqian_gmail.com updated the diff for D37356: bhyve: fix the number of queue feature setting timing for nvme controller..
address reviewer feedback.
wanpengqian_gmail.com added a comment to D37355: bhyve: nvme controller obey async event setting when reporting critical temperature.
address feedback
wanpengqian_gmail.com updated the diff for D37355: bhyve: nvme controller obey async event setting when reporting critical temperature.
drop init value of report_crit
wanpengqian_gmail.com added a comment to D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..
I agree with chuck. fw_num_slots can't be zero. If it's zero, your controller will be broken and you can't rely on any of these values. So, I think it makes no sense to keep the if.
wanpengqian_gmail.com updated the diff for D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..
unconditionly print fw_slot1_ro.
wanpengqian_gmail.com added a comment to D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..
I think Chuck is right. output fw_num_slots unconditionally, but for Firmware Slot 1 Read-Only, we have to make sure the fw_num_slots is bigger than zero. othersize it is meaningless. Although the NVMe controller should at least have one firmware slot.
wanpengqian_gmail.com updated the diff for D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..
unconditionally print fw_num_slots.
Nov 10 2022
Nov 10 2022
wanpengqian_gmail.com reclaimed D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.
All right, I think for unimplemented features, always return FEATURE NOT CHANGEABLE is compliant to the spec. and for implemented features, it is up to the implementation.so I am reclaiming this patch. thanks.
@corvink Can you please help me verify if this patch solve the issue? it needs an Intel SSD for verifying.
wanpengqian_gmail.com added a reviewer for D32845: nvme: fix wrong temperature unit for INTEL SSDs.: corvink.
wanpengqian_gmail.com added a comment to D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
Address reviewers' feedback.
wanpengqian_gmail.com updated the diff for D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
Address reviews' feedback.
Nov 9 2022
Nov 9 2022
Oct 28 2022
Oct 28 2022
wanpengqian_gmail.com updated the diff for D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.
- remove a unnecessary include
- fix typo
- fix code style of switch
wanpengqian_gmail.com updated the summary of D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.
wanpengqian_gmail.com updated the diff for D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.
- combine all changes to one commit.
- build check with CURRENT source.
- correct manpages
Oct 21 2022
Oct 21 2022
wanpengqian_gmail.com added a comment to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
I have built a test ISO and it works as expected within the BHYVE virtual machine with following conditions
Oct 20 2022
Oct 20 2022
wanpengqian_gmail.com added inline comments to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
wanpengqian_gmail.com updated the diff for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
Update as reviewer suggested.
Oct 19 2022
Oct 19 2022
wanpengqian_gmail.com added a comment to D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
@imp I am sorry for the previous samsung patch that I didn't compile on the i386 platform to have checked.
wanpengqian_gmail.com added a comment to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
@kevans I am sorry I just picked up the latest commiter from bsdinstall history,
maybe you can take a look for this patch. I have been suffering from this issue for many years.
wanpengqian_gmail.com added a comment to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
In D32936#826849, @chuck wrote:The code changes do not match the title or summary. Did you update the wrong review?
wanpengqian_gmail.com updated the diff for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
Rollback to previous diff.
wanpengqian_gmail.com updated the diff for D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.
Update code as requested.
Can we give a go for this patch?
wanpengqian_gmail.com updated the diff for D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
catch up with the latest source.
wanpengqian_gmail.com retitled D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller. from bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with save flag. to bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
wanpengqian_gmail.com added a comment to D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
In D33866#838287, @imp wrote:Just some minor style cleanup, and I'll commit.
I'll use the author name of:
Wanpeng Qian <wanpengqian@gmail.com>
wanpengqian_gmail.com added a comment to D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
- Fix code style, match style(9) as @imp requested.
- Fix typo and uppercase vendor‘s name as @pauamma requested.
wanpengqian_gmail.com updated the diff for D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
- Commit new files(by miss).
wanpengqian_gmail.com updated the diff for D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
- Update manpage, fix typo and uppercase vendor's name.
- Fix code style, match style(9)
Oct 17 2022
Oct 17 2022
wanpengqian_gmail.com added a comment to D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.
I tested with 14.0-CURRENT Oct 10 2022, and it works. Is it the right direction for dynamically changing the disk size after hosts resize the disk?
Oct 7 2022
Oct 7 2022
wanpengqian_gmail.com updated the diff for D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
Update to match the latest source.
Update manpage.
Sep 30 2022
Sep 30 2022
wanpengqian_gmail.com added a comment to D33749: nvmecontrol: Add Samsung Extended SMART Information logpage support..
In D33749#835893, @bcr wrote:Who's going to commit this? Seems like it's as complete as it can get.
Sep 5 2022
Sep 5 2022
wanpengqian_gmail.com added a comment to D36450: bhyve/virtio: add config option to change the subvendor.
Can we have a universal PCI vendor/subvendor setting for all PCI devices instead of for particular PCI devices? other pci devices may want to change the ID/subID too. For example, if I want to fake the NVMe controller as an Intel one.
Aug 31 2022
Aug 31 2022
wanpengqian_gmail.com updated the diff for D36345: bhyve: nvme set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfication suggested.
remove comments.
wanpengqian_gmail.com updated the diff for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
remove comments
Aug 29 2022
Aug 29 2022
Here is the compare result with smartctl, for a intel optane 16GB nvme drive
Aug 26 2022
Aug 26 2022
wanpengqian_gmail.com planned changes to D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.
wanpengqian_gmail.com planned changes to D32831: bhyve: implement SELF-TEST feature for NVMe controller.
Aug 25 2022
Aug 25 2022
wanpengqian_gmail.com retitled D36345: bhyve: nvme set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfication suggested from Set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfica
ton suggested. to bhyve: nvme set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfication suggested.
Although I insist on adding the calculation of PowerOnHours. For now, this patch only adds the init value of PowerCycles.
wanpengqian_gmail.com retitled D32558: bhyve: initial PowerCycles value from bhyve: initial PowerCycles value and implement PowerOnHours caculation to bhyve: initial PowerCycles value.
As reviewer suggested, only init PowerCycles value for now.
@imp Can we give a go for this?
Apr 6 2022
Apr 6 2022
I got a intel Xe DG1 dedicated graphics adapter. I will try it later.
Mar 29 2022
Mar 29 2022
wanpengqian_gmail.com retitled D32659: bhyve: fix incorrect Slot1 Read Only setting in NVMe controller. from bhyve: fix Number of Firmware Slot and Slot1 ReadOnly advertise are ignored. to bhyve: fix incorrect Slot1 Read Only setting in NVMe controller..
Any comments?
wanpengqian_gmail.com added a reviewer for D33856: nvmecontrol: Fix IEEE OUI Identifier output.: chuck.
wanpengqian_gmail.com added a comment to D32831: bhyve: implement SELF-TEST feature for NVMe controller.
In D32831#785808, @chuck wrote:While I agree that using emulated hardware to test drivers and system tools is useful, I'm concerned about adding synthetic functionality to the core code.
wanpengqian_gmail.com added a comment to D32798: bhyve: implement get-feature of LBA range type of NVMe controller.
In D32798#786036, @chuck wrote:What is the long term plan for this functionality? Applications can use LBA Range Type to provide usage hints to the Controller such that it can optimize its performance characteristics. Are there kernels / applications out there that use this functionality? If so, is the goal to use these hints to modify the emulation's behavior?
wanpengqian_gmail.com added a comment to D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
Any comments?
wanpengqian_gmail.com added a comment to D32903: bhyve: implement Timestamp get/set feature for NVMe controller.
In D32903#786080, @chuck wrote:This does not appear to implement either Set or Get correctly. For example, it does not use the Timestamp Origin field on Get's.
In D32558#785800, @chuck wrote:After some further thought, I've changed my mind and don't believe it makes sense to include the "power on hours" calculation. The goal of this value in actual hardware is to provide a (weak) heuristic to predict when to replace the drive. But this doesn't make sense for an emulated drive. Correcting the initialization of power on count seems like a good change, but the addition of a synthetic hours doesn't.
wanpengqian_gmail.com updated the diff for D32659: bhyve: fix incorrect Slot1 Read Only setting in NVMe controller..
remove incorrect oacs setting.
Mar 28 2022
Mar 28 2022
wanpengqian_gmail.com added a comment to D32657: bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller.
Can we merge this patch to HEAD?
wanpengqian_gmail.com added inline comments to D32659: bhyve: fix incorrect Slot1 Read Only setting in NVMe controller..
Mar 25 2022
Mar 25 2022
wanpengqian_gmail.com added a comment to D32658: bhyve: initial Active Firmware Info for NVMe controller.
Any comments on this?
Obviously guest OS will work properly without this patch, but we can make the simulation more real.