Page MenuHomeFreeBSD

nvmecontrol: Add Micron Vendor Unique SMART logpage support
AcceptedPublic

Authored by wanpengqian_gmail.com on Jan 12 2022, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 3:07 AM
Unknown Object (File)
Tue, Apr 30, 9:14 AM
Unknown Object (File)
Sun, Apr 28, 11:38 PM
Unknown Object (File)
Fri, Apr 26, 12:01 PM
Unknown Object (File)
Feb 24 2024, 5:26 PM
Unknown Object (File)
Feb 19 2024, 8:29 AM
Unknown Object (File)
Feb 11 2024, 12:04 AM
Unknown Object (File)
Feb 2 2024, 6:18 PM
Subscribers

Details

Reviewers
imp
pauamma_gundo.com
Group Reviewers
manpages
Summary

Micron 9200 SSD has a 0xca logpage. It is different from other vendors
this patch tested on 9200 SSD and works as expected.

Product Datasheet can be found here:
https://www.micron.com/-/media/client/global/documents/products/data-sheet/ssd/9200_u_2_pcie_ssd.pdf

Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com>

Test Plan

print 0xca logpage of Micron 9200 SSD and the output looks like following:

Vendor Unique SMART Log
=========================
F9 NAND Writes 1GiB        : 106518 GiB
FA NAND Reads 1GiB         : 25589 GiB
EA Thermal Throttle Status : inactive
E7 Temperature             : max 360 K, 86.85 C, 188.33 F
                           : min 301 K, 27.85 C, 82.13 F
                           : cur 329 K, 55.85 C, 132.53 F
E8 Power Consumption       : max 10 W, min 8 W, ave 8 W
AF Power Loss Protection   : success 100

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47893
Build 44780: arc lint + arc unit

Event Timeline

wanpengqian_gmail.com retitled this revision from nvmecontrol: Add Micron Vendor Unique SMART Attributes logpage support to nvmecontrol: Add Micron Vendor Unique SMART logpage support.Jan 12 2022, 11:07 PM

Update to match the latest source.
Update manpage.

bcr added a subscriber: bcr.

Man page looks good, thanks!

Just some minor style cleanup, and I'll commit.
I'll use the author name of:
Wanpeng Qian <wanpengqian@gmail.com>
per prior commits unless I hear otherwise.

sbin/nvmecontrol/modules/micron/micron.c
92

FreeBSD style wants

if (foo)
    bar();

that is, the statement for the if on a separate line, here and blow.

96

Also on two lines please, per style(9).

Minor nits, fixable on commit.

sbin/nvmecontrol/nvmecontrol.8
255–257

I think these are the proper capitalizations.

281

Fix that typo while here?

This revision is now accepted and ready to land.Oct 9 2022, 5:47 PM
  • Update manpage, fix typo and uppercase vendor's name.
  • Fix code style, match style(9)
This revision now requires review to proceed.Oct 19 2022, 1:44 AM
wanpengqian_gmail.com marked 2 inline comments as done.
  • Commit new files(by miss).
  • Fix code style, match style(9) as @imp requested.
  • Fix typo and uppercase vendor‘s name as @pauamma requested.
This revision is now accepted and ready to land.Oct 19 2022, 2:18 AM
In D33866#838287, @imp wrote:

Just some minor style cleanup, and I'll commit.
I'll use the author name of:
Wanpeng Qian <wanpengqian@gmail.com>

I have updated the revision as requested. The name is correct.
Thank you.

@imp I am sorry for the previous samsung patch that I didn't compile on the i386 platform to have checked.