Page MenuHomeFreeBSD
Differential D33866

nvmecontrol: Add Micron Vendor Unique SMART logpage support
ClosedPublic
Actions

Authored by wanpengqian_gmail.com on Jan 12 2022, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 25, 9:47 PM
Unknown Object (File)
Thu, Sep 24, 7:19 AM
Unknown Object (File)
Thu, Sep 24, 6:50 AM
Unknown Object (File)
Thu, Sep 24, 6:40 AM
Unknown Object (File)
Thu, Sep 24, 6:38 AM
Unknown Object (File)
Thu, Sep 24, 4:29 AM
Unknown Object (File)
Sun, Sep 20, 7:12 AM
Unknown Object (File)
Sun, Sep 20, 7:12 AM
View All Files
Subscribers
bcr
dab
ziaee

Details

Reviewers
imp
pauamma_chezdork.com
Group Reviewers
manpages
Summary

Micron 9200 SSD has a 0xca logpage. It is different from other vendors
this patch tested on 9200 SSD and works as expected.

Product Datasheet can be found here:
https://www.micron.com/-/media/client/global/documents/products/data-sheet/ssd/9200_u_2_pcie_ssd.pdf

Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com>

Test Plan

print 0xca logpage of Micron 9200 SSD and the output looks like following:

Vendor Unique SMART Log
=========================
F9 NAND Writes 1GiB        : 106518 GiB
FA NAND Reads 1GiB         : 25589 GiB
EA Thermal Throttle Status : inactive
E7 Temperature             : max 360 K, 86.85 C, 188.33 F
                           : min 301 K, 27.85 C, 82.13 F
                           : cur 329 K, 55.85 C, 132.53 F
E8 Power Consumption       : max 10 W, min 8 W, ave 8 W
AF Power Loss Protection   : success 100

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47893
Build 44780: arc lint + arc unit

Event Timeline

wanpengqian_gmail.com created this revision.Jan 12 2022, 1:33 PM
Herald added a subscriber: dab. · View Herald TranscriptJan 12 2022, 1:33 PM
wanpengqian_gmail.com requested review of this revision.Jan 12 2022, 1:33 PM
Harbormaster completed remote builds in B43883: Diff 101360.Jan 12 2022, 1:33 PM
wanpengqian_gmail.com edited the test plan for this revision. (Show Details)Jan 12 2022, 1:34 PM
wanpengqian_gmail.com retitled this revision from nvmecontrol: Add Micron Vendor Unique SMART Attributes logpage support to nvmecontrol: Add Micron Vendor Unique SMART logpage support.Jan 12 2022, 11:07 PM
wanpengqian_gmail.com updated this revision to Diff 101394.Jan 12 2022, 11:09 PM

Correct some words.

Harbormaster completed remote builds in B43895: Diff 101394.Jan 12 2022, 11:09 PM
wanpengqian_gmail.com edited the test plan for this revision. (Show Details)Jan 12 2022, 11:11 PM
wanpengqian_gmail.com updated this revision to Diff 111545.Oct 7 2022, 8:58 AM

Update to match the latest source.
Update manpage.

Harbormaster completed remote builds in B47732: Diff 111545.Oct 7 2022, 8:58 AM
wanpengqian_gmail.com added reviewers: manpages, pauamma_chezdork.com.Oct 7 2022, 9:00 AM
bcr accepted this revision as: manpages.Oct 7 2022, 9:18 AM
bcr added a subscriber: bcr.

Man page looks good, thanks!

imp added a comment.Oct 7 2022, 11:53 PM

Just some minor style cleanup, and I'll commit.
I'll use the author name of:
Wanpeng Qian <wanpengqian@gmail.com>
per prior commits unless I hear otherwise.

sbin/nvmecontrol/modules/micron/micron.c
92

FreeBSD style wants

if (foo)
    bar();

that is, the statement for the if on a separate line, here and blow.

96

Also on two lines please, per style(9).

pauamma_chezdork.com accepted this revision.Oct 9 2022, 5:47 PM

Minor nits, fixable on commit.

sbin/nvmecontrol/nvmecontrol.8
255–257

I think these are the proper capitalizations.

281

Fix that typo while here?

This revision is now accepted and ready to land.Oct 9 2022, 5:47 PM
wanpengqian_gmail.com updated this revision to Diff 111948.Oct 19 2022, 1:44 AM
  • Update manpage, fix typo and uppercase vendor's name.
  • Fix code style, match style(9)
This revision now requires review to proceed.Oct 19 2022, 1:44 AM
Harbormaster completed remote builds in B47892: Diff 111948.Oct 19 2022, 1:44 AM
wanpengqian_gmail.com updated this revision to Diff 111949.Oct 19 2022, 1:48 AM
wanpengqian_gmail.com marked 2 inline comments as done.
  • Commit new files(by miss).
Harbormaster completed remote builds in B47893: Diff 111949.Oct 19 2022, 1:48 AM
wanpengqian_gmail.com marked 2 inline comments as done.Oct 19 2022, 1:50 AM
  • Fix code style, match style(9) as @imp requested.
  • Fix typo and uppercase vendor‘s name as @pauamma requested.
pauamma_chezdork.com accepted this revision.Oct 19 2022, 2:18 AM

Manual page LGTM.

This revision is now accepted and ready to land.Oct 19 2022, 2:18 AM
wanpengqian_gmail.com added a comment.Oct 19 2022, 2:47 AM
In D33866#838287, @imp wrote:

Just some minor style cleanup, and I'll commit.
I'll use the author name of:
Wanpeng Qian <wanpengqian@gmail.com>

I have updated the revision as requested. The name is correct.
Thank you.

wanpengqian_gmail.com added a comment.Oct 19 2022, 8:27 AM

@imp I am sorry for the previous samsung patch that I didn't compile on the i386 platform to have checked.

imp added a comment.Aug 10 2025, 3:16 AM

With a minor tweak to call print_temp_C, this compiles now (I think that's a change I've made).
I'm sorry I lost track of this, I'll commit shortly.

Herald added a subscriber: ziaee. · View Herald TranscriptAug 10 2025, 3:16 AM
imp mentioned this in rG72170a4174e0: nvmecontrol: Add Micron Vendor Unique SMART logpage support.Aug 10 2025, 4:12 AM
wanpengqian_gmail.com closed this revision.Sep 30 2025, 2:20 AM

Revision Contents
Changeset List

PathSize
sbin/
nvmecontrol/
modules/
2 lines
micron/
6 lines
129 lines
7 lines

Diff 111949

View Options

sbin/nvmecontrol/modules/Makefile

Loading...
View Options

sbin/nvmecontrol/modules/micron/Makefile

Loading...
View Options

sbin/nvmecontrol/modules/micron/micron.c

Loading...
View Options

sbin/nvmecontrol/nvmecontrol.8

Loading...