Page MenuHomeFreeBSD

nvme: improve selftest option for nvmecontrol
Changes PlannedPublic

Authored by wanpengqian_gmail.com on Nov 4 2021, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 15, 6:02 PM
Unknown Object (File)
Wed, Jan 11, 5:53 AM
Unknown Object (File)
Fri, Jan 6, 4:12 PM
Unknown Object (File)
Dec 15 2022, 12:20 AM
Unknown Object (File)
Dec 14 2022, 6:18 AM
Unknown Object (File)
Dec 8 2022, 12:00 PM
Unknown Object (File)
Dec 7 2022, 5:27 AM
Unknown Object (File)
Dec 7 2022, 12:58 AM

Details

Reviewers
imp
Group Reviewers
manpages
Summary

selftest now can specify -a to abort a selftest operation, -s to start a short selftest operation, -e to start a extended selftest operation.
also can speccify special namespace, such as 0xFFFFFFFF for all active namespaces.

Test Plan

execute selftest to check the result.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42598
Build 39486: arc lint + arc unit

Event Timeline

These changes look good to me.

This revision is now accepted and ready to land.Nov 4 2021, 3:19 PM
This revision now requires review to proceed.Nov 4 2021, 3:19 PM
rpokala added inline comments.
sbin/nvmecontrol/nvmecontrol.8
532

In English, "An nsid" sounds better than "A nsid".

While the rule is usually "an :vowel::alpha:*" / "a :consonant::alpha:*", when the letter "n" is pronounced as a standalone letter (as in "N S I D" or "N SID"), the first *sound* is vowel-forward "en".

536

"specifies that the device self-test operation be run on the controller, independent of any namespaces."

541

"specifies that the device self-test operation be run on all active namespaces."

sbin/nvmecontrol/selftest.c
114

"Abort option"

152

"Execute short self-test"

154

"Execute extended self-test"

Fix grammer/comments as reviewer suggested.

sbin/nvmecontrol/nvmecontrol.8
532

I seems OK for me, I copy this sentence from identify section. do I need to modify that one?

-n      The namespace ⟨nsid⟩ to use instead of the namespace associated
        with the device.  A nsid of “0” is used to retrieve the
        IDENTIFY_CONTROLLER data associated with that drive.
sbin/nvmecontrol/nvmecontrol.8
511

"an extended"

532

Yes, please update that one too.

Fix grammer/comments as reviewer suggested.

Manual page LGTM at this point; will rereview when it's no longer a WIP.