Page MenuHomeFreeBSD

bhyve: nvme controller obey async event setting when reporting critical temperature
ClosedPublic

Authored by wanpengqian_gmail.com on Nov 11 2022, 7:59 AM.
Tags
None
Referenced Files
F111528540: D37355.id113111.diff
Tue, Mar 4, 9:16 PM
Unknown Object (File)
Sat, Feb 22, 2:36 PM
Unknown Object (File)
Fri, Feb 14, 4:12 AM
Unknown Object (File)
Mon, Feb 10, 1:28 PM
Unknown Object (File)
Wed, Feb 5, 1:57 PM
Unknown Object (File)
Wed, Feb 5, 12:45 PM
Unknown Object (File)
Jan 27 2025, 4:40 PM
Unknown Object (File)
Jan 18 2025, 9:26 PM

Details

Summary

async event report is controlled by async event configuration feature setting.
when reporting a critical temperature warning, check the async event configuration.

Test Plan

trigger a critical temperature event whether the on/off setting is effective.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink added inline comments.
usr.sbin/bhyve/pci_nvme.c
1761

address feedback

usr.sbin/bhyve/pci_nvme.c
1761

this init value will be overridden by the following statement. I think giving an init value to false is reasonable at first.

This revision is now accepted and ready to land.Nov 14 2022, 10:48 AM