Page MenuHomeFreeBSD

bhyve: nvme controller obey async event setting when reporting critical temperature
ClosedPublic

Authored by wanpengqian_gmail.com on Nov 11 2022, 7:59 AM.
Tags
None
Referenced Files
F123373979: D37355.diff
Mon, Jul 14, 4:41 AM
Unknown Object (File)
Sat, Jul 12, 2:19 AM
Unknown Object (File)
Fri, Jun 27, 5:59 AM
Unknown Object (File)
Thu, Jun 19, 10:30 AM
Unknown Object (File)
Wed, Jun 18, 11:25 AM
Unknown Object (File)
Mon, Jun 16, 7:51 PM
Unknown Object (File)
Sun, Jun 15, 7:32 PM
Unknown Object (File)
Jun 13 2025, 3:38 AM

Details

Summary

async event report is controlled by async event configuration feature setting.
when reporting a critical temperature warning, check the async event configuration.

Test Plan

trigger a critical temperature event whether the on/off setting is effective.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink added inline comments.
usr.sbin/bhyve/pci_nvme.c
1761

address feedback

usr.sbin/bhyve/pci_nvme.c
1761

this init value will be overridden by the following statement. I think giving an init value to false is reasonable at first.

This revision is now accepted and ready to land.Nov 14 2022, 10:48 AM