Page MenuHomeFreeBSD

bhyve: nvme controller obey async event setting when reporting critical temperature
ClosedPublic

Authored by wanpengqian_gmail.com on Nov 11 2022, 7:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 4:37 PM
Unknown Object (File)
Thu, Oct 9, 4:37 PM
Unknown Object (File)
Thu, Oct 9, 4:37 PM
Unknown Object (File)
Thu, Oct 9, 4:37 PM
Unknown Object (File)
Thu, Oct 9, 2:57 PM
Unknown Object (File)
Sun, Sep 28, 8:58 AM
Unknown Object (File)
Mon, Sep 22, 11:08 PM
Unknown Object (File)
Thu, Sep 18, 10:09 PM

Details

Summary

async event report is controlled by async event configuration feature setting.
when reporting a critical temperature warning, check the async event configuration.

Test Plan

trigger a critical temperature event whether the on/off setting is effective.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink added inline comments.
usr.sbin/bhyve/pci_nvme.c
1761

address feedback

usr.sbin/bhyve/pci_nvme.c
1761

this init value will be overridden by the following statement. I think giving an init value to false is reasonable at first.

This revision is now accepted and ready to land.Nov 14 2022, 10:48 AM