A former ports committer (brd) gave me blanket approval to commit to a few
ports. Maybe it's cheating, but I'm still technically not a ports
committer.
-Alan

In that case it LGTM. Note however that I am not a ports committer, so I can't give you approval to commit.

Cool! Thanks for fixing this, cem.

Fixed by r360088, but I forgot to put the tag in the commit message.

Fixed by r360087, but I forgot to put the tag in the commit message.

For consistency, shouldn't you also tftp_log(LOG_ERR, ...)?

ping @ngie @lwhsu . Are you satisfied with the latest changes?

Hm. How did you discover this problem? Did you try to read an unseekable file or something? And have you run the unit tests with this change?

ping @ngie . Does it look better now?

The change LGTM, but double check your commit message. Is there a missing "not"?

mac_bsdextended: ATFify the tests

I agree with Renato. There's no way to test in_cksum on both endiannesses without using something complicated like qemu. The right approach is to checksum the same input on different platforms, and assert that the result is identical on all. That's what Renato's change does. @renato.riolino_eldorado.org.br I don't think you have a commit bit, right? If not, I can commit the change for you. But I don't have any BE hardware. Can you first confirm that with your change the tests pass on BE hardware on a newish build?

Can we close this review now?

LGTM, but since the reader already has the man page open, you probably don't need to explain the`-F` flag again.

Thanks for such a speedy review!

Make a warning message scarier, and fix a style nit

I didn't closely review tftp-transfer.c, but everything else looks good, especially the tests! Thanks for implementing tests for option processing; I never got around to that.

Good catch! I don't see any reason not to do it your way. In fact, @rwatson anticipated that in his original commit message.

Committed with that last style comment from @mav.

Style changes suggested by Ryan

Done!

timespec.tv_nsec is defined as long, not time_t. So you should be casting to long.