Differential D23400

geli: add a test case for attaching multiple providers with 1 command
ClosedPublic
Actions

Authored by asomers on Jan 28 2020, 5:06 PM.

Tags

None

Referenced Files

	F136405325: D23400.diff
	Mon, Nov 17, 3:41 PM

	Unknown Object (File)
	Sat, Nov 8, 10:47 PM

	Unknown Object (File)
	Sat, Nov 8, 10:58 AM

	Unknown Object (File)
	Wed, Nov 5, 11:52 PM

	Unknown Object (File)
	Wed, Nov 5, 9:44 PM

	Unknown Object (File)
	Mon, Nov 3, 2:53 AM

	Unknown Object (File)
	Sat, Nov 1, 5:51 AM

	Unknown Object (File)
	Thu, Oct 30, 9:54 AM

View All 85 Files

Subscribers

Details

Reviewers

Commits

rS357880: MFC r357211:
rS357211: geli: add a test case for attaching multiple providers with 1 command

Summary

geli: add a test case for attaching multiple providers with 1 command

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jan 28 2020, 5:06 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 28 2020, 5:06 PM

Harbormaster completed remote builds in B28991: Diff 67423.Jan 28 2020, 5:06 PM

LGTM. 8kB is overkill for the key, but mostly harmless.

tests/sys/geom/class/eli/attach_test.sh
85 ↗	(On Diff #67423)	I don't know what geli does with it, but 32 bytes (256 bits) is completely sufficient as a key. I checked and geli doesn't reject 256 bit keys. Unfortunately, it does accept keys smaller than 256 bits. It also accepts keys smaller than 128 bits :-(. This is probably a bug we should fix (orthogonal to this test). I filed PR 243676.

This revision is now accepted and ready to land.Jan 28 2020, 5:25 PM

Closed by commit rS357211: geli: add a test case for attaching multiple providers with 1 command (authored by asomers). · Explain WhyJan 28 2020, 6:32 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS357211: geli: add a test case for attaching multiple providers with 1 command.

asomers added a commit: rS357880: MFC r357211:.Feb 13 2020, 8:46 PM

Revision Contents
Changeset List

Path

Size

head/

tests/

sys/

geom/

class/

eli/

31 lines

Diff 67428

head/tests/sys/geom/class/eli/attach_test.sh

Loading...