Page MenuHomeFreeBSD
Differential D23127

tests: fusefs: silence remaining unsigned/signed comparison warnings
ClosedPublic
Actions

Authored by kevans on Jan 10 2020, 9:13 PM.
Tags
None
Referenced Files
F169993195: D23127.id.diff
Thu, Sep 3, 5:13 AM
F169793723: D23127.diff
Wed, Sep 2, 2:23 PM
Unknown Object (File)
Tue, Sep 1, 5:21 AM
Unknown Object (File)
Mon, Aug 31, 3:05 PM
Unknown Object (File)
Mon, Aug 31, 1:55 PM
Unknown Object (File)
Mon, Aug 31, 9:37 AM
Unknown Object (File)
Sat, Aug 29, 1:57 PM
Unknown Object (File)
Sat, Aug 29, 6:35 AM
View All Files
Subscribers
imp

Details

Reviewers
asomers
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rS356614: tests: fusefs: silence remaining unsigned/signed comparison warnings
Summary

External GCC turns these into errors; cast to long to silence them.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Jan 10 2020, 9:13 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 10 2020, 9:13 PM
Harbormaster completed remote builds in B28593: Diff 66601.Jan 10 2020, 9:13 PM
asomers requested changes to this revision.Jan 10 2020, 9:19 PM

timespec.tv_nsec is defined as long, not time_t. So you should be casting to long.

This revision now requires changes to proceed.Jan 10 2020, 9:19 PM
kevans updated this revision to Diff 66603.Jan 10 2020, 9:22 PM
kevans edited the summary of this revision. (Show Details)

Whoops, fix types.

Harbormaster completed remote builds in B28594: Diff 66603.Jan 10 2020, 9:23 PM
asomers accepted this revision.Jan 10 2020, 9:28 PM
This revision is now accepted and ready to land.Jan 10 2020, 9:28 PM
Closed by commit rS356614: tests: fusefs: silence remaining unsigned/signed comparison warnings (authored by kevans). · Explain WhyJan 10 2020, 9:51 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rS356614: tests: fusefs: silence remaining unsigned/signed comparison warnings.
Owners added a reviewer: Restricted Owners Package.Jan 10 2020, 9:51 PM

Revision Contents
Changeset List

PathSize
head/
tests/
sys/
fs/
fusefs/
6 lines

Diff 66605

View Options

head/tests/sys/fs/fusefs/setattr.cc

Loading...