Page MenuHomeFreeBSD

renato.riolino_eldorado.org.br (Renato Riolino)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2020, 12:04 PM (73 w, 5 d)

Recent Activity

Mar 25 2020

renato.riolino_eldorado.org.br accepted D23926: Swap words order instead of bits order on BIG ENDIAN.
Mar 25 2020, 7:46 PM

Mar 24 2020

renato.riolino_eldorado.org.br added a comment to D23193: ICMP checksum test: Fix for big endian.

I agree with Renato. There's no way to test in_cksum on both endiannesses without using something complicated like qemu. The right approach is to checksum the same input on different platforms, and assert that the result is identical on all. That's what Renato's change does. @renato.riolino_eldorado.org.br I don't think you have a commit bit, right? If not, I can commit the change for you. But I don't have any BE hardware. Can you first confirm that with your change the tests pass on BE hardware on a newish build?

Mar 24 2020, 11:10 AM · tests

Mar 3 2020

renato.riolino_eldorado.org.br updated the diff for D23926: Swap words order instead of bits order on BIG ENDIAN.

Adjust code style

Mar 3 2020, 11:57 AM
renato.riolino_eldorado.org.br updated the diff for D23623: [POWERPC] Handles float point exception.

Moved exception type check from trap.c to fpu.c

Mar 3 2020, 11:36 AM · PowerPC

Mar 2 2020

renato.riolino_eldorado.org.br created D23927: Fixes on lib/msun kyua test to deal with fp exceptions on power pc.
Mar 2 2020, 4:56 PM · tests
renato.riolino_eldorado.org.br created D23926: Swap words order instead of bits order on BIG ENDIAN.
Mar 2 2020, 4:48 PM
renato.riolino_eldorado.org.br updated the diff for D23623: [POWERPC] Handles float point exception.

Passing SIGFPE on emulated FPU as well.

Mar 2 2020, 11:55 AM · PowerPC

Feb 18 2020

renato.riolino_eldorado.org.br updated the diff for D23623: [POWERPC] Handles float point exception.

Fixed order for calling save_fpu() and enable_fpu()

Feb 18 2020, 4:53 PM · PowerPC
renato.riolino_eldorado.org.br updated the diff for D23623: [POWERPC] Handles float point exception.

Treating fpe exceptions as integers instead of bitfields and calling save_fpu() when detected the signal as been FPE.

Feb 18 2020, 1:26 PM · PowerPC

Feb 12 2020

renato.riolino_eldorado.org.br updated the diff for D23193: ICMP checksum test: Fix for big endian.

Original test wasn't working on BE. Just swaping the input data and testing on the same platform is not the same as testing the same input on a different platform. The best prove that in_cksum is enadiannes independent is that the same input outputs the same value on both platforms as long as you test the output byte-a-byte.

Feb 12 2020, 2:26 PM · tests
renato.riolino_eldorado.org.br updated the diff for D23623: [POWERPC] Handles float point exception.

Using a uint64_t instead of a union as suggested by luporl

Feb 12 2020, 2:02 PM · PowerPC
renato.riolino_eldorado.org.br updated the diff for D23623: [POWERPC] Handles float point exception.

Fixes pointed by jhibbits and luporl and a test of endianess when checking the type of fp exception.

Feb 12 2020, 1:04 PM · PowerPC
renato.riolino_eldorado.org.br added inline comments to D23623: [POWERPC] Handles float point exception.
Feb 12 2020, 1:02 PM · PowerPC

Feb 11 2020

renato.riolino_eldorado.org.br planned changes to D23193: ICMP checksum test: Fix for big endian.

Ok, now it makes sense. But then something is wrong with the test or with the in_cksum implementation, since it is failing on all tests on BE. For been independent of the endianess, I suppose the result checksum for {0x12, 0x34, 0x56, 0x78} and {0x34, 0x12, 0x78, 0x56} should be the same, right?

Feb 11 2020, 7:09 PM · tests
renato.riolino_eldorado.org.br created D23623: [POWERPC] Handles float point exception.
Feb 11 2020, 6:33 PM · PowerPC

Jan 27 2020

renato.riolino_eldorado.org.br updated renato.riolino_eldorado.org.br.
Jan 27 2020, 6:36 PM
renato.riolino_eldorado.org.br created D23382: Fix feholdexcept() on powerpc referencing the wrong struct member.
Jan 27 2020, 5:43 PM

Jan 21 2020

renato.riolino_eldorado.org.br updated the diff for D23280: Fix nmtree crashing with duplicate items.

Diff now is against freebsd tree

Jan 21 2020, 10:51 AM

Jan 20 2020

renato.riolino_eldorado.org.br updated the diff for D23280: Fix nmtree crashing with duplicate items.

Fix for #192839 - Duplicate entries in an mtree file cause nmtree to coredump

Jan 20 2020, 6:07 PM
renato.riolino_eldorado.org.br created D23280: Fix nmtree crashing with duplicate items.
Jan 20 2020, 5:21 PM

Jan 15 2020

renato.riolino_eldorado.org.br created D23193: ICMP checksum test: Fix for big endian.
Jan 15 2020, 4:54 PM · tests
renato.riolino_eldorado.org.br added a comment to D23191: hexdump test: take into account byte order.

Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.

Jan 15 2020, 4:14 PM · tests
renato.riolino_eldorado.org.br updated the diff for D23191: hexdump test: take into account byte order.

Fix speeling "be" and "le" to "eb" and "el"

Jan 15 2020, 4:08 PM · tests
renato.riolino_eldorado.org.br created D23191: hexdump test: take into account byte order.
Jan 15 2020, 2:25 PM · tests