Bump portrevision in kcov, which depends on elfutils ABI.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| devel/elfutils/Makefile | ||
|---|---|---|
| 52 ↗ | (On Diff #71139) | Why are you reading from LOCALBASE ? |
| devel/elfutils/files/patch-libdw_dwarf__getsrclines.c | ||
| 3 ↗ | (On Diff #71139) | You probably don't need to regenerate this patch file, just to change the line numbers. |
| devel/elfutils/pkg-plist | ||
| 43 ↗ | (On Diff #71139) | Shouldn't there be a %%MANPAGES%% here? |
| devel/elfutils/Makefile | ||
|---|---|---|
| 52 ↗ | (On Diff #71139) | The port depends on files installed by gnulib. Is there a more canonical location to reference a dependency’s files? |
| devel/elfutils/files/patch-libdw_dwarf__getsrclines.c | ||
| 3 ↗ | (On Diff #71139) | This is just what ‘make makepatch’ did. |
| devel/elfutils/pkg-plist | ||
| 43 ↗ | (On Diff #71139) | I don’t know. Should there? |
| devel/elfutils/Makefile | ||
|---|---|---|
| 52 ↗ | (On Diff #71139) | Ok, I understand now. gnulib is weird because it installs .c files. I'll do some grepping to see if I can find any other similar ports. |
| devel/elfutils/pkg-plist | ||
| 43 ↗ | (On Diff #71139) | Yes, there should be. And there should be a MANPAGES option that defaults to on. |
| devel/elfutils/Makefile | ||
|---|---|---|
| 52 ↗ | (On Diff #71139) | The best example I can find of a port in a similar state is devel/git-merge-changelog. Would its technique be appropriate here? |
Comment Actions
Thanks for looking at this, Alan.
| devel/elfutils/Makefile | ||
|---|---|---|
| 52 ↗ | (On Diff #71139) | gnulib's behavior is functionally somewhat similar to installing a static library + headers, except of course consumers have to build the installed sources themselves. (I am not sure why the gnulib port does not provide a precompiled static archive, honestly. There's no reason not to and it would make consumer ports more straightforward. If gnulib were an ordinary library, wouldn't we be linking against it in LOCALBASE as well?) The devel/git-merge-changelog approach doesn't look too different from this, aside from invoking gnulib-tool, which does who-knows-what. In elfutils, we know which files we want to build and just cp them directly. I'm not seeing any obvious improvement, but I am probably missing something. |
| devel/elfutils/pkg-plist | ||
| 43 ↗ | (On Diff #71139) | Ok. I will look for examples to borrow. Thanks! |
Comment Actions
In that case it LGTM. Note however that I am not a ports committer, so I can't give you approval to commit.
Comment Actions
Ah, I thought you were a ports committer because you have many ports commits (e.g., r532045, r527149, r526945, r518780) without "Approved by." @jrm, any chance you can approve?
Comment Actions
A former ports committer (brd) gave me blanket approval to commit to a few
ports. Maybe it's cheating, but I'm still technically not a ports
committer.
-Alan
Comment Actions
I see a failure at the configure stage. ./configure: 8857: Syntax error: word unexpected (expecting ")").
Comment Actions
That's odd. Configure is just generated shell script from the autoconf toolset — it should be super portable.
| devel/elfutils/Makefile | ||
|---|---|---|
| 51–55 ↗ | (On Diff #71191) | Is there a special reason this is done in pre-patch and not pre-configure, it does not seems that it has anything to do with patching. When this ends up in pre-configure, the PATCH_DEPENDS can be changed to a BUILD_DEPENDS and the port will stop being strange, |
Comment Actions
This is what line 8857 looks like. PKG_CHECK_MODULES(libmicrohttpd,libmicrohttpd >= 0.9.33,,enable_debuginfod=no)
| devel/elfutils/Makefile | ||
|---|---|---|
| 31–32 ↗ | (On Diff #71191) | If this really is always required, should it just be USES=NLS? |
Comment Actions
That looks like configure.ac m4 rather than generated configure shell to me. On my system configure does not have anything like that line, but does have a much more verbose 20-30 lines where it looks for that library and version, sometimes with pkgconf.
Comment Actions
- Use pre-configure instead of post-patch
- Use BUILD_DEPEND instead of PATCH_DEPEND
Thanks, mat
Comment Actions
Any other suggestions or can we update this port to the current upstream version? Thanks!
Comment Actions
The configure error, which occurs in a clean poudriere jail, needs to be resolved. If it's happening in poudriere, there is almost certainly going to be package building fallout.
Comment Actions
Build looks good on 12 i386/amd64 but fails for 11 i386/amd64.
http://pkg.awarnach.mathstat.dal.ca/data/11i386-default/2020-05-06_00h32m42s/logs/errors/elfutils-0.179.log
http://pkg.awarnach.mathstat.dal.ca/data/11amd64-default/2020-05-06_00h32m42s/logs/errors/elfutils-0.179.log
Comment Actions
Thanks.
If you are feeling motivated for a subsequent commit, you could silence some of the warnings from portclippy, portfmt, and portlint.