vfs_extattr: Allow extattr names up to the full max
ClosedPublic
Actions

Authored by cem on Apr 27 2020, 2:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 10, 11:59 AM

	Unknown Object (File)
	Sat, May 9, 6:33 PM

	Unknown Object (File)
	Wed, Apr 29, 1:30 PM

	Unknown Object (File)
	Wed, Apr 29, 1:24 PM

	Unknown Object (File)
	Tue, Apr 28, 4:26 PM

	Unknown Object (File)
	Tue, Apr 28, 4:19 PM

	Unknown Object (File)
	Tue, Apr 28, 2:57 PM

	Unknown Object (File)
	Mon, Apr 27, 6:10 PM

View All Files

Subscribers

imp

Details

Reviewers

asomers
ngie
emaste

Commits

rS361021: vfs_extattr: Allow extattr names up to the full max

Summary

Extattr names are allowed to be 255 bytes -- not 254 bytes plus trailing
NUL. Provide a 256 buffer so that copyinstr() has room for the trailing
NUL.

Re-enable test for maximal name lengths.

PR: 208965

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem requested review of this revision.Apr 27 2020, 2:13 AM

cem created this revision.

Harbormaster completed remote builds in B30746: Diff 71029.Apr 27 2020, 2:13 AM

Cool! Thanks for fixing this, cem.

This revision is now accepted and ready to land.Apr 27 2020, 2:23 AM

Closed by commit rS361021: vfs_extattr: Allow extattr names up to the full max (authored by cem). · Explain WhyMay 14 2020, 3:01 AM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS361021: vfs_extattr: Allow extattr names up to the full max.

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2020, 3:01 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_extattr.c

28 lines

usr.sbin/

extattr/

tests/

extattr_test.sh

3 lines

Diff 71748

View Options

head/sys/kern/vfs_extattr.c