Aug 31 2020
I didn't think that MMC CAM supported the 'partitions' that mmc can do... that's half of the partitions listed...
I think strlcpy is wrong. serial_num and device_id are documented as follows:
Aug 30 2020
A new review? If so, I suggest that you close this one and give a pointer to the new one.
Aug 29 2020
This looks OK to my eyes, modulo the comments about HEXDUMP_PAGER ifdef and how that gets defined... But I'm good either way with that...
Aug 28 2020
Ah, just use the standard definition of offsetof.
this isn't needed either...
this isn't needed, remove it.
Last second tweaks that I missed the need for before a full build.
Much of the problematic elements of this patch can be fixed by using the proper facilities, and/or extending a couple.
I've taken the liberty of doing this work for you and posting the review to https://reviews.freebsd.org/D26218
Aug 27 2020
last minute nits
I think one key problem is that there are setups where non-"global" root can provoke event notification -- not only this poses question about proper sanitization of data, it poses the question what to do with flooding the device. For example jailed root can be allowed to mount/unmount filesystems which now triggers a HUGE message.
Aug 26 2020
Update per kib/kevans review. Fixed the things I added, but didn't try
to do them all that were pre-existing.
- Retire devctl_notify_f()
Will do another spin... sbuf isn't setup for 'callouts' like this :(
Aug 25 2020
Ping? Are we good? Or have I missed something ?
Ping? Are people OK with implementing 4.4BSD behavior, or do I need to the re-echo twice?
looks good to me.
Aug 24 2020
update zone creation when disable and to cope with the tunable case.
handle destory now.
Aug 23 2020
Aug 22 2020
Update per comments from kib@ and my comparison to 4.4BSD and NetBSD's
implementations. We should be closer in edge cases to historic behavior,
if not actually match historic behavior.
update to use sbuf, though in a bit of a naughty way.
Aug 21 2020
crib off NetBSD / our old implementation for how to implement FLUSHO.