Page MenuHomeFreeBSD
Differential D26235

zalloc_malloc:Free hexdump preceeding buffer when we detect overflow
ClosedPublic
Actions

Authored by sjg on Aug 29 2020, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 1:44 AM
Unknown Object (File)
Wed, Apr 16, 1:56 AM
Unknown Object (File)
Sat, Apr 12, 7:00 AM
Unknown Object (File)
Sat, Apr 12, 6:54 AM
Unknown Object (File)
Sat, Apr 5, 7:23 AM
Unknown Object (File)
Mar 13 2025, 8:14 AM
Unknown Object (File)
Mar 12 2025, 12:33 PM
Unknown Object (File)
Mar 12 2025, 11:55 AM
View All Files
Subscribers
imp

Details

Reviewers
imp
kevans
stevek
Commits
rS364965: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow
Summary

Move hexdump from stand/common/misc.c to stand/libsa/hexdump.c
(svn cp)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sjg created this revision.Aug 29 2020, 7:51 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 29 2020, 7:51 PM
sjg requested review of this revision.Aug 29 2020, 7:51 PM
Harbormaster completed remote builds in B33228: Diff 76349.Aug 29 2020, 7:51 PM
sjg added reviewers: imp, kevans, stevek.Aug 29 2020, 7:54 PM

Added the HEXDUMP_PAGER #ifdef, since otherwise pager (which we do not need in this case) causes linking issue for boot1

stevek added inline comments.Aug 29 2020, 8:00 PM
stand/libsa/hexdump.c
43 ↗(On Diff #76349)

This doesn't look right. Copy/paste error?

sjg updated this revision to Diff 76351.Aug 29 2020, 8:05 PM

fix typo

Harbormaster completed remote builds in B33229: Diff 76351.Aug 29 2020, 8:05 PM
sjg marked an inline comment as done.Aug 29 2020, 8:06 PM
imp accepted this revision.Aug 29 2020, 8:14 PM

This looks OK to my eyes, modulo the comments about HEXDUMP_PAGER ifdef and how that gets defined... But I'm good either way with that...

stand/libsa/hexdump.c
41 ↗(On Diff #76351)

where do we define this?

This revision is now accepted and ready to land.Aug 29 2020, 8:14 PM
sjg updated this revision to Diff 76352.Aug 29 2020, 8:49 PM

fix typo

This revision now requires review to proceed.Aug 29 2020, 8:49 PM
Harbormaster completed remote builds in B33230: Diff 76352.Aug 29 2020, 8:49 PM
sjg updated this revision to Diff 76355.Aug 29 2020, 8:57 PM

fix typo

Harbormaster completed remote builds in B33231: Diff 76355.Aug 29 2020, 8:57 PM
sjg added inline comments.Aug 29 2020, 8:59 PM
stand/libsa/hexdump.c
41 ↗(On Diff #76351)

We don't - at least not in libsa
the only usage there dumps 512 bytes which does not need pager.

stevek accepted this revision.Aug 29 2020, 9:05 PM
This revision is now accepted and ready to land.Aug 29 2020, 9:05 PM
Closed by commit rS364965: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow (authored by sjg). · Explain WhyAug 29 2020, 9:06 PM
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rS364965: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow.

Revision Contents
Changeset List

PathSize
head/
stand/
common/
1 line
40 lines
libsa/
5 lines
79 lines
2 lines
3 lines
11 lines

Diff 76356

View Options

head/stand/common/bootstrap.h

Loading...
View Options

head/stand/common/misc.c

Loading...
View Options

head/stand/libsa/Makefile

Loading...
View Options

head/stand/libsa/hexdump.c

Loading...
View Options

head/stand/libsa/pkgfs.c

Loading...
View Options

head/stand/libsa/stand.h

Loading...
View Options

head/stand/libsa/zalloc_malloc.c

Loading...