Page MenuHomeFreeBSD
Differential D26235

zalloc_malloc:Free hexdump preceeding buffer when we detect overflow
ClosedPublic
Actions

Authored by sjg on Aug 29 2020, 7:51 PM.
Tags
None
Referenced Files
F166276241: D26235.id76349.diff
Wed, Aug 12, 4:06 PM
F166275906: D26235.id76355.diff
Wed, Aug 12, 4:05 PM
F166275902: D26235.id76356.diff
Wed, Aug 12, 4:05 PM
F166275831: D26235.id76351.diff
Wed, Aug 12, 4:05 PM
F166275825: D26235.id76352.diff
Wed, Aug 12, 4:05 PM
F166275745: D26235.diff
Wed, Aug 12, 4:05 PM
Unknown Object (File)
Mon, Aug 10, 9:22 AM
Unknown Object (File)
Fri, Aug 7, 10:33 PM
View All Files
Subscribers
imp

Details

Reviewers
imp
kevans
stevek
Commits
rS364965: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow
Summary

Move hexdump from stand/common/misc.c to stand/libsa/hexdump.c
(svn cp)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33229
Build 30571: arc lint + arc unit

Event Timeline

sjg created this revision.Aug 29 2020, 7:51 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 29 2020, 7:51 PM
sjg requested review of this revision.Aug 29 2020, 7:51 PM
Harbormaster completed remote builds in B33228: Diff 76349.Aug 29 2020, 7:51 PM
sjg added reviewers: imp, kevans, stevek.Aug 29 2020, 7:54 PM

Added the HEXDUMP_PAGER #ifdef, since otherwise pager (which we do not need in this case) causes linking issue for boot1

stevek added inline comments.Aug 29 2020, 8:00 PM
stand/libsa/hexdump.c
46

This doesn't look right. Copy/paste error?

sjg updated this revision to Diff 76351.Aug 29 2020, 8:05 PM

fix typo

Harbormaster completed remote builds in B33229: Diff 76351.Aug 29 2020, 8:05 PM
sjg marked an inline comment as done.Aug 29 2020, 8:06 PM
imp accepted this revision.Aug 29 2020, 8:14 PM

This looks OK to my eyes, modulo the comments about HEXDUMP_PAGER ifdef and how that gets defined... But I'm good either way with that...

stand/libsa/hexdump.c
41

where do we define this?

This revision is now accepted and ready to land.Aug 29 2020, 8:14 PM
sjg updated this revision to Diff 76352.Aug 29 2020, 8:49 PM

fix typo

This revision now requires review to proceed.Aug 29 2020, 8:49 PM
Harbormaster completed remote builds in B33230: Diff 76352.Aug 29 2020, 8:49 PM
sjg updated this revision to Diff 76355.Aug 29 2020, 8:57 PM

fix typo

Harbormaster completed remote builds in B33231: Diff 76355.Aug 29 2020, 8:57 PM
sjg added inline comments.Aug 29 2020, 8:59 PM
stand/libsa/hexdump.c
41

We don't - at least not in libsa
the only usage there dumps 512 bytes which does not need pager.

stevek accepted this revision.Aug 29 2020, 9:05 PM
This revision is now accepted and ready to land.Aug 29 2020, 9:05 PM
Closed by commit rS364965: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow (authored by sjg). · Explain WhyAug 29 2020, 9:06 PM
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rS364965: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow.

Revision Contents
Changeset List

PathSize
stand/
common/
1 line
40 lines
libsa/
5 lines
2 lines
3 lines
11 lines
libsa/
common/
hexdump.c
misc.c
163 lines

Diff 76351

View Options

stand/common/bootstrap.h

Loading...
View Options

stand/common/misc.c

Loading...
View Options

stand/libsa/Makefile

Loading...
View Options

stand/libsa/hexdump.c

Loading...
View Options

stand/libsa/pkgfs.c

Loading...
View Options

stand/libsa/stand.h

Loading...
View Options

stand/libsa/zalloc_malloc.c

Loading...