Page MenuHomeFreeBSD

zalloc_malloc:Free hexdump preceeding buffer when we detect overflow
ClosedPublic

Authored by sjg on Aug 29 2020, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 8:15 PM
Unknown Object (File)
Feb 23 2024, 7:03 PM
Unknown Object (File)
Feb 23 2024, 2:42 PM
Unknown Object (File)
Feb 23 2024, 2:41 PM
Unknown Object (File)
Feb 23 2024, 2:41 PM
Unknown Object (File)
Feb 23 2024, 2:41 PM
Unknown Object (File)
Feb 23 2024, 2:41 PM
Unknown Object (File)
Feb 23 2024, 2:06 PM
Subscribers

Details

Summary

Move hexdump from stand/common/misc.c to stand/libsa/hexdump.c
(svn cp)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33231
Build 30573: arc lint + arc unit

Event Timeline

sjg requested review of this revision.Aug 29 2020, 7:51 PM

Added the HEXDUMP_PAGER #ifdef, since otherwise pager (which we do not need in this case) causes linking issue for boot1

stand/libsa/hexdump.c
45

This doesn't look right. Copy/paste error?

sjg marked an inline comment as done.Aug 29 2020, 8:06 PM

This looks OK to my eyes, modulo the comments about HEXDUMP_PAGER ifdef and how that gets defined... But I'm good either way with that...

stand/libsa/hexdump.c
41

where do we define this?

This revision is now accepted and ready to land.Aug 29 2020, 8:14 PM
This revision now requires review to proceed.Aug 29 2020, 8:49 PM
stand/libsa/hexdump.c
41

We don't - at least not in libsa
the only usage there dumps 512 bytes which does not need pager.

This revision is now accepted and ready to land.Aug 29 2020, 9:05 PM