• use dt_free() instead of free()
• add error checks after calls to dt_alloc() and dt_node_xalloc()

diff against main, not last patch

Address Mark's comments.

Fix a recent lowpc/highpc bug I made accidentally, embed GElf_Shdr into
the section struct, replace emalloc() with dt_alloc(), fix libraries in Makefiles.

Typo fixes.

Print dnp as well.

s/stdout/standard output/

In D38732#881813, @markj wrote:

In D38732#881808, @0mp wrote:

Would it be wiser to implement this as an extension to the -x flag?

This option is in the same vein as -S, whereas -x is used to set runtime parameters for the dtrace script. So, -x feels like the wrong place to me, but maybe I'm missing something?

In D38732#881808, @0mp wrote:

Would it be wiser to implement this as an extension to the -x flag?

Would it be wiser to implement this as an extension to the -x flag?

Move dump code to dt_cc.c.

Looks good 👍

Bump port to 1.2 so we catch latest development (the inclusion of a dashboard for the Block I/O stats)

I'm a dork -- *NOW* it looks right :)

Fix distinfo

that looks better

the distinfo change doesn't look right?

Update diff before applying to head

I was working on committing this and went to go apply the patch to the tree and the patch no longer applies cleanly.

LGTM -- feel free to ping me to commit, or use Approved by: ler

Add missing dashboard examples from 1.1

Fixup package COMMENT to match what I have set for 1.1

Pepper [@]sample

In D36051#824457, @woodsb02 wrote:

You’re probably already aware, but ports has a commit hook so that commit messages should start the first line with “category/portname: description”.

So commit message should have first line:
sysutils/dwatch-json: update to 1.1, restore maintainership

You’re probably already aware, but ports has a commit hook so that commit messages should start the first line with “category/portname: description”.

All the proposed changes look fine to me. You’re welcome to commit this to ports yourself with my ports commit bit approval.

Reclaim

Tested and ready for re-review

Add missing io-sample conf

makesum for 1.1

Add symbolic link entries from 1.1

Add missing config to plist for 1.1

Update pkg-descr for 1.1

Update the plist for 1.1

Abandon the update to 0.5 and update to 1.1

From my 2018 BSDCAN presentation slides, here are the modules in base ... we're not going to add "dwatch-" prefix to all those simply because a PORT convention says that a PORT should install files named the same as the PORT when the PORT should follow BASE convention already set forth 6 years ago

In D36051#818573, @diizzy wrote:

I discussed this submission with dteske on IRC and possibly have a few suggestions:

PORTNAME should correspond to the naming convention of installed files and usecase whenever possible, so dwatch-json --> dwatch-json-net and preferably libexec/dwatch/json-net* --> libexec/dwatch/dwatch-json-net*

Grafnet should be broken out, put in a separate port and be set as a dependency (if required) as it doesn't seem to be a hard requirement and/or limited to dwatch-json-net looking at pkg-descr

I discussed this submission with dteske on IRC and possibly have a few suggestions:

In D30778#692250, @markj wrote:

In D30778#692214, @domagoj.stolfa_gmail.com wrote:

In D30778#691982, @markj wrote:

If there are any tags, e.g., sponsored by, please add them to the review description and I'll commit.

You can add a Signed-off-by: domagoj.stolfa@gmail.com if you'd like

I prefer not to since we don't have a policy around it, at least not yet. If you prefer to have it, then I'll keep it.

In D30778#692214, @domagoj.stolfa_gmail.com wrote:

In D30778#691982, @markj wrote:

If there are any tags, e.g., sponsored by, please add them to the review description and I'll commit.

You can add a Signed-off-by: domagoj.stolfa@gmail.com if you'd like

In D30778#691982, @markj wrote:

If there are any tags, e.g., sponsored by, please add them to the review description and I'll commit.

If there are any tags, e.g., sponsored by, please add them to the review description and I'll commit.

@markj 's comments.

Added -x libdir and -x syslibdir as suggested by @markj

Thanks. Would you also consider documenting -x libdir and -x syslibdir while here?

In D29435#659665, @markj wrote:

(Please let me know if you'd like me to commit this.)

(Please let me know if you'd like me to commit this.)

Thanks, this looks right to me.

Trim exclusion of memcpy() and bcopy() as @andrew's in-progress patch to
avoid improper FBT instrumentation of functions without conventional stack
frames now solves that problem in a better way.