Differential D38892

libdtrace: embed kernel bootfile in dtrace_hdl_t
AbandonedPublic
Actions

Authored by christos on Mar 3 2023, 4:18 PM.

Tags

Referenced Files

	Unknown Object (File)
	Wed, May 17, 8:13 PM

	Unknown Object (File)
	Thu, May 11, 8:40 AM

	Unknown Object (File)
	Sat, May 6, 10:36 AM

	Unknown Object (File)
	May 4 2023, 4:24 AM

	Unknown Object (File)
	Apr 26 2023, 4:33 AM

	Unknown Object (File)
	Apr 8 2023, 8:57 PM

	Unknown Object (File)
	Apr 4 2023, 1:15 AM

	Unknown Object (File)
	Mar 21 2023, 6:23 PM

View All 13 Files

Subscribers

Details

Reviewers

markj
gnn

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

christos created this revision.Mar 3 2023, 4:18 PM

Herald added a reviewer: gnn. · View Herald TranscriptMar 3 2023, 4:18 PM

Herald added a subscriber: imp. · View Herald Transcript

christos requested review of this revision.Mar 3 2023, 4:18 PM

markj accepted this revision.Mar 3 2023, 4:21 PM

markj added inline comments.

cddl/contrib/opensolaris/lib/libdtrace/common/dt_open.c
1320	Let's make the fallback value "/boot/kernel/kernel" rather than "kernel". The code below won't notice the difference, and that's better for other consumers which might expect an absolute path.

This revision is now accepted and ready to land.Mar 3 2023, 4:21 PM

christos updated this revision to Diff 118265.Mar 3 2023, 4:23 PM

christos marked an inline comment as done.

This revision now requires review to proceed.Mar 3 2023, 4:23 PM

christos added a child revision: D38825: libdtrace: implement inline function tracing for kinst.Mar 3 2023, 4:25 PM

markj accepted this revision.Mar 8 2023, 3:23 PM

This revision is now accepted and ready to land.Mar 8 2023, 3:23 PM

christos removed a child revision: D38825: libdtrace: implement inline function tracing for kinst.Mar 20 2023, 11:30 PM

Since D38825 doesn't need this patch anymore, is this needed?

In D38892#893746, @christos wrote:

Since D38825 doesn't need this patch anymore, is this needed?

I think we can drop this one, indeed.

christos abandoned this revision.Mar 24 2023, 7:53 PM

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

lib/

libdtrace/

common/

1 line

11 lines

Diff 118265

cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h

Loading...

cddl/contrib/opensolaris/lib/libdtrace/common/dt_open.c

Loading...