Should I be the one to commit this, then?

Does anyone on this review know why this is necessary on 12.0+? I think we were supposed to be doing this in the first place, but I don't know why this stopped working.

The description should mention that this also affects/fixes ixv(4), too.

I'll commit this for Jake and try to get it into 12-RELEASE

@krzysztof.galazka_intel.com I think @shurd's version here is better in that it masks isc_capabilities before togging RXCSUM/RXCSUM_IPV6. Though I think if you had added that, they might be roughly similar.

Looks like it does what it's supposed to.

In D17404#375201, @krzysztof.galazka_intel.com wrote:

In D17404#373883, @shurd wrote:

iflib_admin_intr_deferred() called with STATE_LOCK() in a few places.

I've moved STATE_UNLOCK before iflib_admin_intr_defereed call although releasing lock just to immediately grab it again makes me a bit uneasy. Maybe it would be better idea to use mtx_owned in iflib_in_detach to check if this lock is already aquired?

Err, "arc patch" doesn't apply this cleanly to my svn tree -- it complains that it can't find the new files if_iavf.c, iavf_vc.c, and iavf.h to patch.

In D17544#374994, @sbruno wrote:

@erj do you want to ask RE permission to commit this?

My only nitpick is that ixlvc.c should probably be renamed to iavf_vc.c instead; it's supposed to contain the functions that communicate via the PF<->VF virtchannel.

Any last-minute assents or objections?

I'm going to try to get these committed, soon; I don't have any more planned changes.

@krzysztof.galazka_intel.com , you need to re-upload this patch

I can't tell if this is right or not, but it looks like an ok change to me.

In D17404#372096, @shurd wrote:

Hrm, I don't think we can obtain CTX_LOCK() in those functions.

In D17404#372080, @shurd wrote:

Wouldn't iflib_iov_intr_deferred() need it too?

It's a reasonable change, but it's still kind of a surprise to me that em doesn't support IPv6 hardware offloads.

You're apparently not allowed to delete changesets, so this'll have to be updated with the old diff.

rS339207 has the wrong Differential Revision, I think

In D17404#371923, @shurd wrote:

Is there a reason not to do this in taskqgroup_detach()?

I don't see any obvious thing which prevents something being enqueued between the gtaskqueue_drain() and taskqgroup_detach() calls.

• iavf(4): Move modules/Makefile entry so that it's in alphabetical order
• iavf(4): Update MODULE_* macros with new "iavf" name

• Change name of ixlv(4) to iavf(4) and update Makefile

Sorry guys, ixlv(4) is getting a name change. :p

• ixlv/iavf(4): Change "ixlv" driver name to "iavf"

Ugh, rebasing changes the commit SHAs :(

Rebased onto latest master, and added:

Fix incorrect use of .Fx macro

• Fix style issues found by @0mp

• ixl/ixlv(4): Update both manpages.

• Revert "iflib: Free RX queue TCP LRO memory on unload"

• ixlv(4): Update driver version to 2.0.0-k
• ixlv(4): Remove dynamic ITR code, since it's unused
• ixlv(4): Set max number of queues used in iflib based on number VF receives from PF
• ixlv(4): Code cleanup
• ixlv(4): Don't sleep for a response to a VC msg if driver is in detach
• ixl(4): Clear VF qtag queue flags when VF is being reinitialized
• ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for completion
• ixlv(4): Modify debug prints, and stop printing out "Queue already enabled" warnings
• ixl(4): Update version number to 2.1.0-k

• ixl(4): Fix filter handling when SR-IOV is enabled
• Revert "iflib: Free RX queue TCP LRO memory on unload"

• ixl(4): Fix compile error introduced by previous commit

• ixl(4): Configure promiscuous mode during driver init

• ixlv(4): Disable queues before initialization.

In D16428#360259, @mmacy wrote:

I'm confused; this is just doing a normal store / load for the in detach - you need a lock to serialize reading it with other operations.

• ixlv(4): Swap MALLOC_DEFINE/DECLARE statements
• ixlv(4): Remove commented out code
• ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses
• ixlv(4): Update some debug printf()'s to use newer debug functions
• ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists

• iflib: Destroy state lock at end of iflib_device_deregister()
• iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it

• iflib: Destroy state lock at end of iflib_device_deregister()
• iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
• ixl(4): Fix kernel panic during init() when Admin Queue is not alive

Yes -- I did this quick update because someone mentioned the textproc/igor utility in another review. It also reminded me to come back to this.

• Run manpage through textproc/igor and fix resulting issues

I wish there was a previewer for these...

• ixl/ixlv Missing semicolon in DWB fix

The in-tree igb never sets IFLIB_ADMIN_ALWAYS_RUN. Is this for a modified version of igb?

• ixl(4): Fix memory leak when head writeback is disabled

• ixl/ixlv(4): Fix TXD credits update for DWB mode

Fix typo (from @hselasky)

• ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
• ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message

Can I get this patch re-reviewed before committing it?

• ixl(4): Fix RX MDD event display
• ixl/ixlv(4): Add more MPASS statements to TX path

• if_media: Add 40Gbase-ER4 media type.

In D16731#357695, @hselasky wrote:

I see IFM_40G_ER4 is missing from the table. There is only IFM_40G_LR4 currently.

Can you add IFM_40G_ER4 as part of this patch aswell?

• ixl(4): Enhance Malicious Driver Detection messages with VF information
• ixl(4): Print out additional event information when a LAN Overflow Event occurs
• ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path

• ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
• ixlv(4): Fix a memory leak when interrupt setup fails
• ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
• ixlv(4): Remove comments and commented out code
• ixlv(4): Remove list of media types displayed in "ifconfig -m"

• iflib: Free remaining interrupt resources on failure in iflib_device_register()
• iflib: Free RX queue TCP LRO memory on unload

• ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic