Right now the answer is "We don't have v2, and we have no plans to support v2 either.".
If someone does ever want to add VRRPv2 support they get to deal with the fallout. I'm not inclined to copy/paste chunks of code on the off chance that maybe it'll be slightly helpful in the future.
We're not making choices that'll make that impossible to do in the future.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 3 2024
May 2 2024
In D45039#1027522, @glebius wrote:
May 1 2024
In D44774#1026860, @kp wrote:Split out Gleb's commits again.
It makes the individual changes easier to understand.
Split out Gleb's commits again.
Document that we cannot switch between carp and vrrp
Apr 30 2024
- remove stale comment
- init sc_addr in the initializer
Add glebius' changes from https://github.com/freebsd/freebsd-src/compare/main...glebius:FreeBSD:carp-vrrp
Apr 29 2024
Apr 26 2024
In D44774#1024964, @glebius wrote:If it is possible to set VRRP values while interface is in CARP mode and vice versa, then it is already a bug and de-unionizing just hides it.
Apr 25 2024
In D44774#1024470, @glebius wrote:The switching code should just use a local variable to convert between prio and adnskew.
We can't convert between them. They're not different representations of the same concept, they just represent different things.
Apr 24 2024
In D44774#1024364, @glebius wrote:In D44774#1023611, @kp wrote:Put carp/vrrp3 specific variables in their own structs.
This definitely is better, but I still can't figure out what prevents to unionize it? Do we have a code that switches certain address operation between CARP and VRRP?
Apr 22 2024
In D44774#1020944, @kp wrote:In D44774#1020899, @bz wrote:I will simply express that this will not only open a can of worms by mixing both but the original reasons not to include VRRPv2/3 and hence the "existence" of CARP is also ignored.
I'm assuming you're referring to the supposed patent issues?
There are multiple other open source VRRP implementations, e.g. https://github.com/FDio/vpp/tree/master/src/plugins/vrrp and https://www.keepalived.org
Also, the relevant patents have expired by now (by which I mean, in 2017 and 2012, so 7 and 12 years ago): https://en.wikipedia.org/wiki/Virtual_Router_Redundancy_Protocol#cite_note-6
Put carp/vrrp3 specific variables in their own structs.
Apr 19 2024
Apr 18 2024
Apr 17 2024
Apr 16 2024
Apr 15 2024
In D44774#1020899, @bz wrote:I will simply express that this will not only open a can of worms by mixing both but the original reasons not to include VRRPv2/3 and hence the "existence" of CARP is also ignored.
I'm assuming you're referring to the supposed patent issues?
Apr 13 2024
Apr 8 2024
Apr 5 2024
Allow MIB SDT's to be disabled.
Apr 4 2024
Apr 3 2024
In D43504#1017242, @gallatin wrote:In the meantime, could you have a compile option to avoid these probes? Maybe re-do your new macros to use IP_SDT_PROBE" which can be defined to a noop if "NO_EXTRA_IP_SDT_PROBES" or some better named kernel config option is present?
Apr 1 2024
Mar 30 2024
In D43504#1016001, @gallatin wrote:I lost my benchmark box yesterday. It will take me a few days to wrangle another one into shape for testing. I'm sorry this is taking so long. If you want to go ahead and push this, I'd understand..
Mar 28 2024
Mar 25 2024
Mar 24 2024
This also really needs a test case.
In D43504#1014598, @gallatin wrote:
Mar 23 2024
In D44476#1014459, @glebius wrote:In D44476#1014446, @kp wrote:When we build without VIMAGE VNET_SYSUNINIT translates to SYSUNINIT, so this patch means we leak V_icmp_rates[i].cr_rate on shutdown.
That's not exactly a critical problem, but this is technically wrong.I don't agree with that. We don't deallocate memory on shutdown in general case. We do not have a matching SYSUNINIT for every SYSINIT that mallocs. Keeping a function to deallocate memory on shutdown is the actual waste of memory - it grows kernel text, which is wired.
When we build without VIMAGE VNET_SYSUNINIT translates to SYSUNINIT, so this patch means we leak V_icmp_rates[i].cr_rate on shutdown.
Mar 22 2024
In D43504#1013955, @glebius wrote:To put it lightly, I'd really like to see this patch performance tested.
Mar 21 2024
I'd like to land this patch. Absent anyone raising objections I intend to do so in two weeks or so.
Mar 19 2024
Mar 15 2024
Mar 12 2024
Mar 8 2024
Mar 1 2024
Feb 28 2024
Feb 27 2024
In D44088#1006073, @zlei wrote:Will this be MFCed to stable branches ? I see sys/netlink/route/nexthop.c is consuming the fixed function nlattr_get_uint8():
sys/netlink/route/nexthop.c: { .type = NHAF_FAMILY, .off = _OUT(nhaf_family), .cb = nlattr_get_uint8 },
Feb 26 2024
In D44089#1005840, @melifaro wrote:I’ a bit unsure about this one - as having pointer to bool may introduce