carp: refactor packet tagging for ether_output()
ClosedPublic
Actions

Authored by kp on May 1 2024, 9:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 13, 4:46 AM

	Unknown Object (File)
	Sun, Feb 8, 2:21 PM

	Unknown Object (File)
	Sun, Feb 8, 11:37 AM

	Unknown Object (File)
	Sat, Jan 31, 12:30 AM

	Unknown Object (File)
	Nov 20 2025, 6:02 AM

	Unknown Object (File)
	Nov 8 2025, 5:51 AM

	Unknown Object (File)
	Nov 5 2025, 6:39 PM

	Unknown Object (File)
	Nov 5 2025, 4:13 PM

Subscribers

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG601438fbfa8e: carp: refactor packet tagging for ether_output()

Summary

Separate HMAC preparation (CARP specific) from tagging.
In unicast mode (CARP specific) don't put tag at all.
Don't put pointer to software context into the tag. Putting just vhid, an integer value, is a safer design.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.May 1 2024, 9:43 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptMay 1 2024, 9:43 AM

kp requested review of this revision.May 1 2024, 9:43 AM

Harbormaster completed remote builds in B57488: Diff 137932.May 1 2024, 9:43 AM

kp added a parent revision: D45037: carp: assert that we are calling correct input function. We are..May 1 2024, 9:43 AM

kp added a child revision: D45039: carp: isolate VRRP from CARP.

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2024, 11:21 AM

Closed by commit rG601438fbfa8e: carp: refactor packet tagging for ether_output() (authored by glebius, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG601438fbfa8e: carp: refactor packet tagging for ether_output().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_carp.c

37 lines

Diff 138232

View Options

carp: refactor packet tagging for ether_output()ClosedPublicActions