carp: don't chain call vrrp_send_ad via carp_send_ad
ClosedPublic
Actions

Authored by kp on May 1 2024, 9:43 AM.

Tags

None

Referenced Files

	F132357489: D45036.id137930.diff
	Thu, Oct 16, 5:07 AM

	F132357487: D45036.id138230.diff
	Thu, Oct 16, 5:07 AM

	F132357482: D45036.id.diff
	Thu, Oct 16, 5:07 AM

	Unknown Object (File)
	Wed, Oct 15, 5:59 PM

	Unknown Object (File)
	Sat, Oct 11, 4:41 AM

	Unknown Object (File)
	Sep 7 2025, 3:00 PM

	Unknown Object (File)
	Sep 7 2025, 12:46 PM

	Unknown Object (File)
	Sep 3 2025, 8:40 AM

Subscribers

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG5ee92cbd82d0: carp: don't chain call vrrp_send_ad via carp_send_ad

Summary

Provide inline send_ad_locked() that switches between protocol
specific sending function.

Rename carp_send_ad() to carp_callout() to avoid getting lost in
all these multiple foo_send_ad.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.May 1 2024, 9:43 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptMay 1 2024, 9:43 AM

kp requested review of this revision.May 1 2024, 9:43 AM

Harbormaster completed remote builds in B57486: Diff 137930.May 1 2024, 9:43 AM

kp added a child revision: D45037: carp: assert that we are calling correct input function. We are..May 1 2024, 9:43 AM

kp added a parent revision: D44776: carp: document the new VRRPv3 support.May 1 2024, 9:47 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2024, 11:20 AM

Closed by commit rG5ee92cbd82d0: carp: don't chain call vrrp_send_ad via carp_send_ad (authored by glebius, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG5ee92cbd82d0: carp: don't chain call vrrp_send_ad via carp_send_ad.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_carp.c

36 lines

Diff 138230

View Options

carp: don't chain call vrrp_send_ad via carp_send_adClosedPublicActions