Page MenuHomeFreeBSD
Differential D44475

icmp: do not store per-VNET identical array of strings
ClosedPublic
Actions

Authored by glebius on Mar 22 2024, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 12, 12:45 PM
Unknown Object (File)
Sat, Oct 10, 9:19 AM
Unknown Object (File)
Mon, Oct 5, 9:23 PM
Unknown Object (File)
Mon, Oct 5, 3:57 AM
Unknown Object (File)
Mon, Oct 5, 2:50 AM
Unknown Object (File)
Mon, Oct 5, 1:58 AM
Unknown Object (File)
Fri, Sep 25, 8:04 PM
Unknown Object (File)
Sep 4 2026, 10:11 PM
View All Files
Subscribers
imp
melifaro
zlei

Details

Reviewers
kp
zlei
tuexen
Group Reviewers
network
Commits
rGebc96321e706: icmp: do not store per-VNET identical array of strings
rG0939f3a04653: icmp: do not store per-VNET identical array of strings
rG2193c63f9ad1: icmp: do not store per-VNET identical array of strings
rG7142ab479066: icmp: do not store per-VNET identical array of strings
Summary

We need per-VNET struct counter_rate, but we don't need per-VNET set of
const char *. Also, identical word "response" can go into the format
string instead of being stored 7 times.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Mar 22 2024, 9:48 PM
Herald added subscribers: melifaro, imp. · View Herald TranscriptMar 22 2024, 9:48 PM
glebius requested review of this revision.Mar 22 2024, 9:48 PM
Harbormaster completed remote builds in B56746: Diff 136104.Mar 22 2024, 9:48 PM
glebius added a child revision: D44476: icmp: hide icmp_bandlimit_uninit() under VIMAGE.Mar 22 2024, 9:48 PM
kp accepted this revision as: kp.Mar 23 2024, 1:19 AM
This revision is now accepted and ready to land.Mar 23 2024, 1:19 AM
zlei accepted this revision as: zlei.Mar 23 2024, 1:55 AM
zlei added a subscriber: zlei.

Looks good to me.

tuexen accepted this revision.Mar 23 2024, 2:20 PM
Closed by commit rG7142ab479066: icmp: do not store per-VNET identical array of strings (authored by glebius). · Explain WhyMar 24 2024, 4:20 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG7142ab479066: icmp: do not store per-VNET identical array of strings.
zlei added a commit: rG2193c63f9ad1: icmp: do not store per-VNET identical array of strings.Jun 26 2024, 4:51 AM
tuexen added a commit: rG0939f3a04653: icmp: do not store per-VNET identical array of strings.Feb 12 2025, 10:20 AM
tuexen added a commit: rGebc96321e706: icmp: do not store per-VNET identical array of strings.Feb 13 2025, 4:46 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
37 lines

Diff 136159

View Options

sys/netinet/ip_icmp.c

Loading...