Page MenuHomeFreeBSD

icmp: improve ICMP limit jitter
ClosedPublic

Authored by glebius on Mar 22 2024, 9:49 PM.
Tags
None
Referenced Files
F103361918: D44478.diff
Sun, Nov 24, 1:23 AM
F103345270: D44478.id136162.diff
Sat, Nov 23, 8:32 PM
Unknown Object (File)
Sat, Nov 23, 7:01 AM
Unknown Object (File)
Fri, Nov 22, 11:43 PM
Unknown Object (File)
Wed, Nov 20, 10:25 PM
Unknown Object (File)
Wed, Nov 20, 4:18 AM
Unknown Object (File)
Tue, Nov 19, 6:59 AM
Unknown Object (File)
Fri, Nov 15, 12:46 PM
Subscribers

Details

Summary

Instead of fixing up invalid values set by a user in badport_bandlim()
which is a fast path function, provide a sysctl handler
sysctl_icmplim_and_jitter(), that will check that jitter is less than the
limit.

Provide jitter initilization function icmplim_new_jitter() used at boot,
in the sysctl handler and when we actually hit the limit. This also fixes
no jitter on a fresh booted system until first limit hit.

Instead of CVE number provide link the the actual paper that explains what
and why we are doing here. The CVE number isn't very informative, it will
just tell you what RedHat version you need to upgrade to.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 23 2024, 3:38 AM
zlei added a subscriber: zlei.

Looks good to me.

This revision was automatically updated to reflect the committed changes.