Page MenuHomeFreeBSD

icmp: improve ICMP limit jitter
ClosedPublic

Authored by glebius on Mar 22 2024, 9:49 PM.
Tags
None
Referenced Files
F86868691: D44478.diff
Wed, Jun 26, 6:58 PM
F86830642: D44478.diff
Wed, Jun 26, 5:53 AM
F86829892: D44478.diff
Wed, Jun 26, 5:37 AM
Unknown Object (File)
Sat, Jun 22, 6:28 AM
Unknown Object (File)
May 14 2024, 9:32 PM
Unknown Object (File)
May 14 2024, 9:31 PM
Unknown Object (File)
May 12 2024, 3:55 AM
Unknown Object (File)
May 12 2024, 3:46 AM
Subscribers

Details

Summary

Instead of fixing up invalid values set by a user in badport_bandlim()
which is a fast path function, provide a sysctl handler
sysctl_icmplim_and_jitter(), that will check that jitter is less than the
limit.

Provide jitter initilization function icmplim_new_jitter() used at boot,
in the sysctl handler and when we actually hit the limit. This also fixes
no jitter on a fresh booted system until first limit hit.

Instead of CVE number provide link the the actual paper that explains what
and why we are doing here. The CVE number isn't very informative, it will
just tell you what RedHat version you need to upgrade to.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56749
Build 53637: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 23 2024, 3:38 AM
zlei added a subscriber: zlei.

Looks good to me.

This revision was automatically updated to reflect the committed changes.