LGTM

In D26447#663603, @eugen_grosbein.net wrote:

Please keep ftp and telnet clients and servers in base system. Removing violates POLA and does not buy anything. Servers already disables by default.

sizeof is a tricky operator, which may return a larger value than you would expect. This depends on the allocation scheme of the compiler, which knows how to pad a structure to the alignment and addressing requirements of the underlying hardware. So in for each of your cases it had to be checked if the comparison should be "==", "<", or ">=" to cope with remote data structures generated externally compiled software.

In D29190#653711, @kp wrote:

Until D29189 it couldn't handle that. This commit builds on top of that.

May you please provide context to the diff?

How common is this requirement?
For normal production the customer is able to set the values manually before compiling.
I don't assume they will wait 3 week before having it in STABLE and some months to have it in RELEASE.

In D28645#648051, @glebius wrote:

1. Keep the historical behavior.

LTGM

Would it not better to not setting the callback on shutdown?

Straightforward.

This will result in STP over Vlan (or PVST ala Cisco) if applied to vlan interfaces.
LTGM

I like, that the ugly "reference" paramenter is gone. It was never used.

Is this a problem of the kernel or the laziness of the arp code?

In D28516#644387, @afedorov wrote:

Did you mean D28559?

• Document behavior in the man page.

• Fix man page

• Add documentation in man page

In D28645#641097, @rgrimes wrote:

Infact it is probalby safer to assume a /24 than a /32.

Is the destroy callout guaranteed to run outside (or on the border) of epoch? Can this callout check the refcount and chase to abort itself?

Inverted logic changes are hard to review.

• Reword some comments.
• Fix loopCount setting.

• Fix move logic after rebase to modifications to the parent review.

• Expose error handling.

• New code uses current best practise for constants.

• Sanity checks on input

• rebase after changes

• Rebase after some changes

• Fix use after lost reference.

Compiles fine (backported to stable/13), but causes kernel panic

• Factor out a send and statistic routine

Overcome by D28559
All write access to this variable will be moved to calls under the WRITER lock.

Rebase

In D28545#639301, @rgrimes wrote:

In D28545#639178, @donner wrote:

In D28545#639176, @rgrimes wrote:

In D28545#638947, @donner wrote:

• Get rid of "hent" instead of "host".

This types of change just cause lots of noise in this review that makes it harder to see the real change.

That's why this change is a secondary modification.
Please choose the relevant part in the revision tab "History"

I do not see what your saying, and what is committed is all of what appears here as a single commit, no seperation, and for that mater, not even a mention that you renamed hent -> host in the commit.

In D28545#639176, @rgrimes wrote:

In D28545#638947, @donner wrote:

• Get rid of "hent" instead of "host".

This types of change just cause lots of noise in this review that makes it harder to see the real change.