Use interface fib instead of RT_DEFAULT_FIB in nd6_ns_output().
Needs ReviewPublic
Actions

Authored by melifaro on Apr 5 2021, 7:28 PM.

Details

Reviewers

hrs
bz

Group Reviewers

network

Summary

IPv6 ND is specific to the interface, so use the interface fib instead of the default one.

This is a follow-up of D1998 and addresses kern/240969.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38703
Build 35592: arc lint + arc unit

Event Timeline

melifaro created this revision.Apr 5 2021, 7:28 PM

Herald added subscribers: bz, ae, imp. · View Herald TranscriptApr 5 2021, 7:28 PM

melifaro requested review of this revision.Apr 5 2021, 7:28 PM

Harbormaster completed remote builds in B38332: Diff 86857.Apr 5 2021, 7:28 PM

melifaro retitled this revision from Use interface fib in nd6_ns_output(). to Use interface fib instead of RT_DEFAULT_FIB in nd6_ns_output()..Apr 5 2021, 7:32 PM

melifaro edited the summary of this revision. (Show Details)

melifaro added reviewers: hrs, bz, network.

donner added a subscriber: donner.Apr 6 2021, 12:16 PM

donner added inline comments.

sys/netinet6/nd6_nbr.c
1101	How about this one?

Update to be consistent with nd6_na_output_fib().

sys/netinet6/nd6_nbr.c
1101	Not used anywhere.

Harbormaster completed remote builds in B38702: Diff 87754.Apr 19 2021, 9:44 PM

Harbormaster completed remote builds in B38703: Diff 87755.Apr 19 2021, 9:56 PM

zlei added a subscriber: zlei.Jul 28 2021, 3:55 AM

zlei added inline comments.

sys/netinet6/nd6_nbr.c
1101	`sys/netinet/ip_carp.c` is using `nd6_na_output`, is `carp` affected?

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

nd6_nbr.c

2 lines

Diff 87755

View Options

Use interface fib instead of RT_DEFAULT_FIB in nd6_ns_output().Needs ReviewPublicActions