bridge: Remove members when assigned to a new vnet
ClosedPublic
Actions

Authored by kp on Feb 22 2021, 2:32 PM.

Details

Reviewers

Group Reviewers

Commits

rG6a0355a0fe75: bridge: Remove members when assigned to a new vnet
rGa20033be9ed8: bridge: Remove members when assigned to a new vnet
rG38c0951386d8: bridge: Remove members when assigned to a new vnet

Summary

When the bridge is moved to a different vnet we must remove all of its
member interfaces (and span interfaces), because we don't know if those
will be moved along with it. We don't want to hold references to
interfaces not in our vnet.

MFC after: 1 week
Sponsored by: Orange Business Services

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Feb 22 2021, 2:32 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptFeb 22 2021, 2:32 PM

Harbormaster completed remote builds in B37268: Diff 84454.Feb 22 2021, 2:32 PM

kp requested review of this revision.Feb 22 2021, 2:32 PM

kp added a child revision: D28860: arp/nd: Cope with late calls to iflladdr_event.Feb 22 2021, 2:33 PM

kp added a parent revision: D28858: bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic.

donner added a subscriber: donner.Feb 22 2021, 5:59 PM

donner added inline comments.

sys/net/if_ethersubr.c
977–979	Remove this too?
1034–1051	dito

kp added inline comments.Feb 22 2021, 6:14 PM

sys/net/if_ethersubr.c
977–979	No, because there are other callers (pretty much every ethernet NIC driver) to ether_ifattach() that we don't want to modify.

donner added inline comments.Feb 22 2021, 7:00 PM

sys/net/if_ethersubr.c
120–122	Why is the prototype removed?

kp added inline comments.Feb 22 2021, 7:05 PM

sys/net/if_ethersubr.c
120–122	It moved to sys/net/ethernet.h so that the function can be used by if_bridge. In essence what we're doing is adding steps in front of the ether_reassign() code for if_bridge.