Fix interface route addition with net/bird.
ClosedPublic
Actions

Authored by melifaro on Feb 11 2021, 11:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 12, 4:32 PM

	Unknown Object (File)
	Wed, Aug 12, 8:58 AM

	Unknown Object (File)
	Tue, Aug 11, 7:06 AM

	Unknown Object (File)
	Tue, Aug 4, 12:27 AM

	Unknown Object (File)
	Mon, Aug 3, 1:47 AM

	Unknown Object (File)
	Fri, Jul 24, 9:01 PM

	Unknown Object (File)
	Jun 15 2026, 7:37 PM

	Unknown Object (File)
	Jun 14 2026, 12:17 PM

Subscribers

Details

Reviewers

donner

Group Reviewers

network

Summary

The case of adding interface route by specifying interface
address as the gateway was missed during code refactoring.
Re-add it back by copying non-AF_LINK gateway data when RTF_GATEWAY
is not set.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36914
Build 33803: arc lint + arc unit

Event Timeline

melifaro created this revision.Feb 11 2021, 11:28 PM

Herald added subscribers: ae, imp. · View Herald TranscriptFeb 11 2021, 11:28 PM

melifaro requested review of this revision.Feb 11 2021, 11:28 PM

Harbormaster completed remote builds in B36914: Diff 83725.Feb 11 2021, 11:28 PM

Inverted logic changes are hard to review.

This revision is now accepted and ready to land.Feb 11 2021, 11:40 PM

is this waiting on anything?

Herald added a subscriber: glebius. · View Herald TranscriptDec 9 2021, 10:02 PM

Committed as 8170a7d43835047f9c1548a081eea45116473995.

Revision Contents
Changeset List

Path

Size

sys/

net/

route/

nhop_ctl.c

50 lines

Diff 83725

View Options

Fix interface route addition with net/bird.ClosedPublicActions