Page MenuHomeFreeBSD
Differential D28673

Make in_localip_more() fib-aware.
ClosedPublic
Actions

Authored by melifaro on Feb 14 2021, 11:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 11:39 PM
Unknown Object (File)
Wed, Dec 4, 2:45 PM
Unknown Object (File)
Sun, Dec 1, 5:16 AM
Unknown Object (File)
Wed, Nov 27, 8:08 AM
Unknown Object (File)
Wed, Nov 27, 2:53 AM
Unknown Object (File)
Tue, Nov 26, 10:06 PM
Unknown Object (File)
Nov 18 2024, 12:50 AM
Unknown Object (File)
Nov 17 2024, 4:49 PM
View All 77 Files
Subscribers
donner
imp

Details

Reviewers
donner
Group Reviewers
network
Commits
rGdba80ca2cfb0: Make in_localip_more() fib-aware.
rGf67641675958: Make in_localip_more() fib-aware.
rG9fdbf7eef5c0: Make in_localip_more() fib-aware.
Summary

This change fixes route installation for the interfaces in the different fibs using the same prefix.

Test Plan
23:29 [0] m@devel2 s ifconfig tap0 create
23:29 [0] m@devel2 s ifconfig tap1 create
23:29 [0] m@devel2 s ifconfig tap1 fib 3
23:30 [0] m@devel2 s ifconfig tap0 fib 2
23:30 [0] m@devel2 s ifconfig tap0 192.0.2.2/24
23:30 [0] m@devel2 s ifconfig tap1 192.0.2.2/24
23:30 [0] m@devel2
23:30 [0] m@devel2 setfib 2 netstat -4rn
Routing tables (fib: 2)

Internet:
Destination        Gateway            Flags     Netif Expire
127.0.0.1          link#2             UHS         lo0
192.0.2.0/24       link#3             U          tap0
192.0.2.2          link#3             UHS         lo0
23:30 [0] m@devel2
23:30 [0] m@devel2 setfib 3 netstat -4rn
Routing tables (fib: 3)

Internet:
Destination        Gateway            Flags     Netif Expire
192.0.2.0/24       link#4             U          tap1
192.0.2.2          link#4             UHS         lo0
23:37 [1] m@devel2 s ifconfig tap1 -alias 192.0.2.2
23:38 [1] m@devel2 setfib 3 netstat -4rn
Routing tables (fib: 3)
23:38 [1] m@devel2 setfib 2 netstat -4rn
Routing tables (fib: 2)

Internet:
Destination        Gateway            Flags     Netif Expire
127.0.0.1          link#2             UHS         lo0
192.0.2.0/24       link#3             U          tap0
192.0.2.2          link#3             UHS         lo0

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro created this revision.Feb 14 2021, 11:36 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 14 2021, 11:36 PM
melifaro requested review of this revision.Feb 14 2021, 11:36 PM
Harbormaster completed remote builds in B37005: Diff 83896.Feb 14 2021, 11:36 PM
melifaro edited the test plan for this revision. (Show Details)Feb 14 2021, 11:38 PM
melifaro added a reviewer: network.
donner added a subscriber: donner.Feb 15 2021, 6:57 AM
donner added inline comments.
sys/netinet/in.c
175

Are you comparing pointers (it_addr vs in) or content?

melifaro updated this revision to Diff 83965.Feb 15 2021, 9:17 PM
melifaro edited the test plan for this revision. (Show Details)

Reflect comments.

Harbormaster completed remote builds in B37038: Diff 83965.Feb 15 2021, 9:17 PM
melifaro added inline comments.Feb 15 2021, 9:22 PM
sys/netinet/in.c
175

No, but in and it were indeed easy to mix up.
Renamed variables, so it should be easier to read.

donner accepted this revision as: donner.Feb 16 2021, 8:10 AM
This revision is now accepted and ready to land.Feb 16 2021, 8:10 AM
Closed by commit rG9fdbf7eef5c0: Make in_localip_more() fib-aware. (authored by melifaro). · Explain WhyFeb 16 2021, 8:04 PM
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG9fdbf7eef5c0: Make in_localip_more() fib-aware..
melifaro added a commit: rGf67641675958: Make in_localip_more() fib-aware..Mar 10 2021, 10:28 PM
melifaro added a commit: rGdba80ca2cfb0: Make in_localip_more() fib-aware..Mar 11 2021, 8:26 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
24 lines

Diff 84036

View Options

sys/netinet/in.c

Loading...