Page MenuHomeFreeBSD
Differential D28650

pf: Slightly relax pf_rule_addr validation
ClosedPublic
Actions

Authored by kp on Sat, Feb 13, 4:33 PM.

Details

Reviewers
donner
Group Reviewers
network
Commits
R10:00abeecb4a25: pf: Slightly relax pf_rule_addr validation
R10:f8d1f2da0922: pf: Slightly relax pf_rule_addr validation
R10:f9a66bb91ae1: pf: Slightly relax pf_rule_addr validation
R10:5e42cb139fc1: pf: Slightly relax pf_rule_addr validation
Summary

Ensure we don't reject no-route / urpf-failed addresses.

PR: 253479
MFC after: 3 days

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp created this revision.Sat, Feb 13, 4:33 PM
Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptSat, Feb 13, 4:33 PM
kp requested review of this revision.Sat, Feb 13, 4:33 PM
Harbormaster completed remote builds in B36971: Diff 83835.Sat, Feb 13, 4:33 PM
donner added a subscriber: donner.Sat, Feb 13, 7:52 PM
donner added inline comments.
sys/netpfil/pf/pf_ioctl.c
1563–1568

May give "switch () { case x: case y: ... " a try. It's easier to maintain and offers more flexibility for the compiler.

kp updated this revision to Diff 83848.Sat, Feb 13, 8:26 PM

Use switch

Harbormaster completed remote builds in B36976: Diff 83848.Sat, Feb 13, 8:27 PM
donner accepted this revision as: donner.Sun, Feb 14, 11:16 AM
This revision is now accepted and ready to land.Sun, Feb 14, 11:16 AM
Closed by commit R10:5e42cb139fc1: pf: Slightly relax pf_rule_addr validation (authored by kp). · Explain WhySun, Feb 14, 12:09 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: R10:5e42cb139fc1: pf: Slightly relax pf_rule_addr validation.
kp added a commit: R10:f9a66bb91ae1: pf: Slightly relax pf_rule_addr validation.Wed, Feb 17, 1:05 PM
kp added a commit: R10:f8d1f2da0922: pf: Slightly relax pf_rule_addr validation.
kp added a commit: R10:00abeecb4a25: pf: Slightly relax pf_rule_addr validation.Wed, Feb 17, 4:50 PM

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
47 lines

Diff 83872

View Options

sys/netpfil/pf/pf_ioctl.c

Loading...