In D25303#558622, @thierry wrote:

I tested it with ECL-20.4.24 from PR 247283, but pkg-plist is not versioned:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/ecl-20.4.24/%%BINNAME%%.fas
Error: Orphaned: man/de/man1/%%BINNAME%%.1.gz
Error: Orphaned: man/ru/man1/%%BINNAME%%.1.gz
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/ecl-16.1.3/%%BINNAME%%.fas

Fix build failures from exp-run

Does it make sense to build mesa-demos without both X11 and WAYLAND support? Perhaps they should be made into an "at least one must be selected" option?
Other than that, I have no further comments, just fix what @jbeich pointed out and it's good to go.

Fix hardcoding of libffi.so.6 in a few places.

I believe this patch has been superseeded by the update of xserver to 1.20.

Abandon this since it has been superseeded by the update of libdrm to 2.4.102 in rP537533.

Keep the shar example, but de-emphasize it and put it at the bottom, as suggested by @mat .

In D25148#555356, @mat wrote:

Could you maybe keep the example as it is now, and add a second example using shar ?

Approved.

It looks very good. I've been quite nit-picky about the patch meta data changes.

approved

Jup, this is good!

Hi!
After discussing this on the Graphics Team meeting today we all agreed that since this is a big update, and we are getting close to both the 11.4 release and the new quarterly ports branch, this has to wait until after the ports tree branch.
This does not mean this is an approval to commit this after the branch, but gives you a timeline of when at the earliest it can go in.

Hi!
This review requires some work to get going, and in our opinion we must get it right, since breaking this will break the whole graphics stack.

Does this require changes to drm-kmods?

Abandoning this since it's closed, but there seem to be no way to indicate that it's closed and committed if there's a mistake with the commit integration.

This has been updated as part of rP533793, but the phab integration missed it.

With regards to the API breakage, there has to be an overlap period where both the old and the new API works in order to have time to update ports, and to have those updates propagate.

Diff updated. I believe I got it right this time. :)

Update based on comments from @wulf .