Differential D32584

Use network epoch to protect local IPv4 addresses hash.
ClosedPublic
Actions

Authored by glebius on Oct 20 2021, 7:33 PM.

Tags

None

Referenced Files

	F149830960: D32584.id97308.diff
	Fri, Mar 27, 10:57 AM

	F149807857: D32584.id97308.diff
	Fri, Mar 27, 6:23 AM

	Unknown Object (File)
	Sun, Mar 22, 12:43 PM

	Unknown Object (File)
	Sat, Mar 21, 10:17 PM

	Unknown Object (File)
	Thu, Mar 19, 6:17 PM

	Unknown Object (File)
	Wed, Mar 11, 9:49 AM

	Unknown Object (File)
	Tue, Mar 10, 5:34 AM

	Unknown Object (File)
	Fri, Feb 27, 7:59 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGc8ee75f2315e: Use network epoch to protect local IPv4 addresses hash.

Summary

The modification to the hash are already naturally locked by
in_control_sx. Convert the hash lists to CK lists. Remove the
in_ifaddr_rmlock. Assert the network epoch where necessary.

Most cases when the hash lookup is done the epoch is already entered.
Cover a few cases, that need entering the epoch, which mostly is
initial configuration of tunnel interfaces and multicast addresses.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Oct 20 2021, 7:33 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptOct 20 2021, 7:33 PM

glebius requested review of this revision.Oct 20 2021, 7:33 PM

Harbormaster completed remote builds in B42280: Diff 97184.Oct 20 2021, 7:33 PM

melifaro accepted this revision as: melifaro.Oct 20 2021, 10:16 PM

This revision is now accepted and ready to land.Oct 20 2021, 10:16 PM

Closed by commit rGc8ee75f2315e: Use network epoch to protect local IPv4 addresses hash. (authored by glebius). · Explain WhyOct 22 2021, 9:56 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGc8ee75f2315e: Use network epoch to protect local IPv4 addresses hash..

Herald added a subscriber: farrokhi. · View Herald TranscriptOct 22 2021, 9:56 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

3 lines

3 lines

6 lines

netinet/

13 lines

2 lines

46 lines

6 lines

3 lines

28 lines

24 lines

3 lines

7 lines

12 lines

netpfil/

pf/

17 lines

Diff 97308

sys/net/if_ipsec.c

Loading...

sys/net/if_me.c

Loading...

sys/net/if_stf.c

Loading...

sys/netinet/if_ether.c

Loading...

sys/netinet/in.h

Loading...

sys/netinet/in.c

Loading...

sys/netinet/in_debug.c

Loading...

sys/netinet/in_gif.c

Loading...

sys/netinet/in_mcast.c

Loading...

sys/netinet/in_var.h

Loading...

sys/netinet/ip_gre.c

Loading...

sys/netinet/ip_icmp.c

Loading...

sys/netinet/ip_input.c

Loading...

sys/netpfil/pf/pf.c

Loading...