Enable MK_LLVM_BINUTILS if MK_ASAN is requested
ClosedPublic
Actions

Authored by arichardson on Jul 5 2021, 5:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 19, 4:06 PM

	Unknown Object (File)
	Sun, Apr 19, 4:05 PM

	Unknown Object (File)
	Sun, Apr 19, 5:41 AM

	Unknown Object (File)
	Sun, Apr 19, 2:21 AM

	Unknown Object (File)
	Wed, Apr 15, 5:35 AM

	Unknown Object (File)
	Sun, Apr 12, 7:42 PM

	Unknown Object (File)
	Mon, Apr 6, 2:49 PM

	Unknown Object (File)
	Sun, Apr 5, 6:44 AM

Subscribers

Details

Reviewers

emaste
markj
dim

Commits

rG24f586182ff4: Enable MK_LLVM_BINUTILS if MK_ASAN is requested

Summary

ASan will not be able to provide backtraces with symbol names with
elftoolchain's addr2line. To fix this turn MK_LLVM_BINUTILS on by
default when ASan instrumentation is requested.

Depends on D31060
Depends on D31043

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Jul 5 2021, 5:47 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJul 5 2021, 5:47 PM

arichardson requested review of this revision.Jul 5 2021, 5:47 PM

Harbormaster completed remote builds in B40318: Diff 91816.Jul 5 2021, 5:47 PM

arichardson added reviewers: emaste, markj, dim.Aug 3 2021, 9:41 AM

markj accepted this revision.Aug 3 2021, 1:14 PM

This revision is now accepted and ready to land.Aug 3 2021, 1:14 PM

emaste accepted this revision.Aug 3 2021, 3:09 PM

Closed by commit rG24f586182ff4: Enable MK_LLVM_BINUTILS if MK_ASAN is requested (authored by arichardson). · Explain WhySep 6 2021, 9:26 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG24f586182ff4: Enable MK_LLVM_BINUTILS if MK_ASAN is requested.

Revision Contents
Changeset List

Path

Size

share/

mk/

src.opts.mk

6 lines

Diff 94715

View Options

Enable MK_LLVM_BINUTILS if MK_ASAN is requestedClosedPublicActions