Eliminate p_elf_machine from struct proc.
ClosedPublic
Actions

Authored by dchagin on Jun 28 2021, 5:25 PM.

Details

Reviewers

markj
kib
jhb

Commits

rGb4b67e41443f: Eliminate p_elf_machine from struct proc.
rG5d9f790191fe: Eliminate p_elf_machine from struct proc.

Summary

Instead of p_elf_machine use machine member of the Elf_Brandinfo which is now
cached in the struct proc at p_elf_brandinfo member.

As p_elf_flags alignment is 8 bytes here is a hole, should I remove p_reserved?

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40146
Build 37035: arc lint + arc unit

Event Timeline

dchagin created this revision.Jun 28 2021, 5:25 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 28 2021, 5:25 PM

dchagin requested review of this revision.Jun 28 2021, 5:25 PM

Harbormaster completed remote builds in B40146: Diff 91446.Jun 28 2021, 5:25 PM

dchagin added reviewers: markj, kib.Jun 28 2021, 5:31 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

dchagin added a reviewer: jhb.Jun 28 2021, 5:34 PM

kib accepted this revision.Jun 28 2021, 5:56 PM

kib added inline comments.

sys/sys/proc.h
703	We do not leave the cruft in system structures (in HEAD), even if it is padding.

This revision is now accepted and ready to land.Jun 28 2021, 5:56 PM

+1 to kib's comment.

Closed by commit rG5d9f790191fe: Eliminate p_elf_machine from struct proc. (authored by dchagin). · Explain WhyJun 29 2021, 5:20 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG5d9f790191fe: Eliminate p_elf_machine from struct proc..

dchagin added a commit: rGb4b67e41443f: Eliminate p_elf_machine from struct proc..Jun 17 2022, 7:33 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

imgact_elf.c

5 lines

sys/

proc.h

2 lines

Diff 91446

View Options

sys/kern/imgact_elf.c